BADGERS-177 Use UTCTiming for wall-clock time
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirikbjornr
added
bug fix
ShiningTrapez
approved these changes
Jun 19, 2023
I did think about that but was unsure whether to port our LoadUrlAsync wrapper to another place. But tbf I can introduce a simple wrapper in the manifestloader. TV module network rewrite when 😭 |
|
☝️@ShiningTrapez On this I looked over again and not worth collapsing IMO. A wrapper wouldn't help in terms of performance or readability because each function interacts with LoadUrl slightly differently. That variation would end up in the promise chain instead. |
Merged
eirikbjornr
added a commit
that referenced
this pull request
Jul 6, 2023
* BADGERS-177 Use `UTCTiming` for wall-clock time (#299) * wip: commit to test upgrading jest * chore: upgrade jest to v29 * test: missing timing resource * fix: hls tests * feat: promisify manifest loader * chore: remove redundant placeholders * test: make MediaSources tests handle promisified manifest loader * feat: return promise from loadManifest * fix: triple load bug * fix: don't provide wallclock time on failover or refresh * feat: log error in dev client * feat: let DebugTool take error objects * feat: log manifest load failure * chore: remove unused vars * docs: reference source * fix: handle load failures with no cause given * feat: add warn method and fix error method * chore: add deprecation note to server date * doc: deprecate server date * fix: move jsdom to dev dependencies * refactor: async/await tests * docs: expand documentation * fix: boolean logic * fix: export mutable * fix: use absolute time to seek sliding window in a failover * chore: remove comment * BADGERS-177 Failover with MPD times in MSE strategy (#302) * style: make magic numbers in tests variables * refactor: optimise manifest regex * test: url with query param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 What
Get wall-clock time from the
<UTCTiming>element present in dynamic DASH manifests.If
serverDateis passed into bigscreen-player oninitthat timing will be used to derive times from the first manifest only. If a new manifest is fetched, or the current manifest is refreshed, then wall-clock time will be derived from<UTCTiming>.Note:
badgers-177, notmaster. I've chunked the ticket into two PRs to make reviews easier.timeCorrectionSecondsnot being updated on failover/refresh (closure bug).🛠 How
Fetches and parses wall-clock time from the timing resource defined by the
<UTCTiming>element on the manifest.Along the way:
mediasourcesto fix tests. Fixed a bug that caused the manifest to be loaded and parsed twice if it failed over whenloadManifestwas called.DebugToolso it formats errors correctlywarnmethod toDebugToolto log a deprecation notice.