Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-op --block_for_lock command option #24953

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 17, 2025

This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing.

This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing.
@fmeum fmeum requested a review from meisterT January 17, 2025 17:33
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 17, 2025

@bazel-io fork 7.5.0

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 17, 2025
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 17, 2025

@bazel-io fork 8.1.0

@meisterT meisterT added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 20, 2025
@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jan 21, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 21, 2025
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 21, 2025
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing.

Closes bazelbuild#24953.

PiperOrigin-RevId: 717853503
Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 21, 2025
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing.

Closes bazelbuild#24953.

PiperOrigin-RevId: 717853503
Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef
github-merge-queue bot pushed a commit that referenced this pull request Jan 21, 2025
This option, which is different from the startup option of the same
name, has no effect and doesn't even show a warning, which can be
confusing.

Closes #24953.

PiperOrigin-RevId: 717853503
Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef

Commit
79508be

Co-authored-by: Fabian Meumertzheim <[email protected]>
@fmeum fmeum deleted the block-for-lock branch January 21, 2025 16:59
github-merge-queue bot pushed a commit that referenced this pull request Jan 21, 2025
This option, which is different from the startup option of the same
name, has no effect and doesn't even show a warning, which can be
confusing.

Closes #24953.

PiperOrigin-RevId: 717853503
Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef

Commit
79508be

Co-authored-by: Fabian Meumertzheim <[email protected]>
fmeum added a commit to fmeum/bazel that referenced this pull request Jan 29, 2025
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing.

Closes bazelbuild#24953.

PiperOrigin-RevId: 717853503
Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants