Skip to content

Commit

Permalink
Remove no-op --block_for_lock command option
Browse files Browse the repository at this point in the history
This option, which is different from the startup option of the same name, has no effect and doesn't even show a warning, which can be confusing.

Closes #24953.

PiperOrigin-RevId: 717853503
Change-Id: I8d7d1229f692007c4350b6c15526b7a95bbed5ef
  • Loading branch information
fmeum authored and copybara-github committed Jan 21, 2025
1 parent 159f67a commit 79508be
Showing 1 changed file with 0 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -471,17 +471,6 @@ public String getTypeDescription() {
help = "Enable processing of +<file> parameters.")
public boolean allowProjectFiles;

@Option(
name = "block_for_lock",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.BAZEL_INTERNAL_CONFIGURATION},
metadataTags = {OptionMetadataTag.HIDDEN},
help =
"If set (the default), a command will block if there is another one running. If "
+ "unset, these commands will immediately return with an error.")
public boolean blockForLock;

// We could accept multiple of these, in the event where there's a chain of tools that led to a
// Bazel invocation. We would not want to expect anything from the order of these, and would need
// to guarantee that the "label" for each command line is unique. Unless a need is demonstrated,
Expand Down

0 comments on commit 79508be

Please sign in to comment.