[8.0.1] Forward @bazel_tools//tools/sh:toolchain_type to rules_shell
#24793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for compatibility with modules that rely on the auto-registered `sh_toolchain` to obtain a shebang, e.g. `rules_js`. Also remove implementations and toolchain registrations in favor of forwarders. Closes bazelbuild#24748. PiperOrigin-RevId: 709149200 Change-Id: I758cf403c24f6b5e6f00bbf5b4e0313a30773f78
bazel-io
added
team-Configurability
meteorcloudy
approved these changes
Jan 2, 2025
github-actions
bot
removed
the
awaiting-review
blg666
approved these changes
Jan 19, 2025
blg666
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for compatibility with modules that rely on the auto-registered
sh_toolchainto obtain a shebang, e.g.rules_js.Also remove implementations and toolchain registrations in favor of forwarders.
Closes #24748.
PiperOrigin-RevId: 709149200
Change-Id: I758cf403c24f6b5e6f00bbf5b4e0313a30773f78
Commit 720e15e