Forward @bazel_tools//tools/sh:toolchain_type to rules_shell
#24748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for compatibility with modules that rely on the auto-registered `sh_toolchain` to obtain a shebang, e.g. `rules_js`. Also remove implementations and toolchain registrations in favor of forwarders.
fmeum
requested review from
gregestren and
meteorcloudy
and removed request for
a team and
gregestren
|
FYI @comius |
github-actions
bot
added
team-Configurability
|
@bazel-io fork 8.0.1 |
fmeum
changed the title
@bazel_tools//tools/sh:toolchain_type to rules_shell@bazel_tools//tools/sh:toolchain_type to rules_shell
|
FYI @alexeagle as this may break |
|
Thank you! I don't think we saw that report yet but perhaps the problem is unreachable due to other Bazel 8 errors. |
meteorcloudy
approved these changes
Dec 19, 2024
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 23, 2024
This is required for compatibility with modules that rely on the auto-registered `sh_toolchain` to obtain a shebang, e.g. `rules_js`. Also remove implementations and toolchain registrations in favor of forwarders. Closes bazelbuild#24748. PiperOrigin-RevId: 709149200 Change-Id: I758cf403c24f6b5e6f00bbf5b4e0313a30773f78
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
…ll` (#24793) This is required for compatibility with modules that rely on the auto-registered `sh_toolchain` to obtain a shebang, e.g. `rules_js`. Also remove implementations and toolchain registrations in favor of forwarders. Closes #24748. PiperOrigin-RevId: 709149200 Change-Id: I758cf403c24f6b5e6f00bbf5b4e0313a30773f78 Commit 720e15e Co-authored-by: Fabian Meumertzheim <[email protected]>
|
The changes in this PR have been included in Bazel 8.0.1 RC1. Please test out the release candidate and report any issues as soon as possible. |
|
I am seeing |
BoleynSu
reviewed
Jan 18, 2025
| def _sh_toolchain_impl(ctx): | ||
| """sh_toolchain rule implementation.""" | ||
| return [platform_common.ToolchainInfo(path = ctx.attr.path)] | ||
| load("@rules_shell//shell:sh_toolchain.bzl", _sh_toolchain = "sh_toolchain") |
There was a problem hiding this comment.
@fmeum this seems to be wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for compatibility with modules that rely on the auto-registered
sh_toolchainto obtain a shebang, e.g.rules_js.Also remove implementations and toolchain registrations in favor of forwarders.