Add release notes for Trilinos 14.0 and break in backward compatibility with -isystem include dirs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty with -isystem include dirs Hopefully this will be enough for Trilinos users to work through problems with changes in the handling of include directories. For more details, see TriBITSPub/TriBITS#443
7 tasks
|
I will need to wait to merge this to my branch 'tribits-299-modern-cmake-targets-1-again' until after I updated the TriBITS snapshot in that branch. |
mperrinel
approved these changes
Mar 4, 2022
bartlettroscoe
commented
Mar 4, 2022
RELEASE_NOTES
Outdated
| critical compiler options and include directories (and other modern CMake | ||
| usage requirements) are propagated through linking to the IMPORTED library | ||
| targets in downstream customer CMake projects. This makes the usage of | ||
| the variables `<Trilinos>_INCLUDE_DIRS` and `Trilinos__TPL_INCLUDE_DIRS` |
There was a problem hiding this comment.
There is an extra _ in Trilinos__TPL_INCLUDE_DIRS. That is an obvious typo.
RELEASE_NOTES
Outdated
| some fragile build environments that have the same header file names in | ||
| multiple include directories searched by the compiler. Also, this will | ||
| silence any regular compiler warnings from headers found under these | ||
| include directories. **This constitutes a break in backward compatibility |
There was a problem hiding this comment.
Where is the matching ** for the bolding? That is an obvious error.
|
@marcinwrobel1986 wrote:
@mperrinel wrote:
Guys, a simple rereading of this this morning and I found at least 9 typos or other errors as listed in my review above. |
bartlettroscoe
force-pushed
the
tribits-299-modern-cmake-targets-1-again-doc
branch
from
2d0bc1c to
6ab23b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related TriBITS PRs are:
For more details, see TriBITSPub/TriBITS#443