Better document <Project>_IMPORTED_NO_SYSTEM and workarounds (#443) #459
Conversation
…Pub#443) * Mentioned dependence on CMake 3.23+ * Mentioned the behavior differences between -I and -isystem * Mentioned it restores backward compatibility for the move to modern CMake * Fixed typos and misspellings
There was a problem hiding this comment.
@bartlettroscoe as said yesterday, I checked the docs. No typos, all good.
@marcinwrobel1986, I created this PR after our meeting yesterday, so you could not have reviewed this new text before that meeting. |
Sorry, I wrote it too fast. I find it confusing as well. What I mean was: as you proposed on yesterday's meeting, that I should review docs and Meriadeg code. I reviewed this today. So sorry for that :) |
There were only a few small typos. Most of the changes were what I consider improvements to make the text more clear.
|
With my latest commit 10d02da, I think this is ready to merge. |
Parent Issue:
Follow up from PR:
I think this is sufficient for TriBITS documentation and release notes related to the handling of
-Ito-isystemchanges in backward compatibility (#443).The rest of the documentation needs to be Trilinos-specific in a Trilinos PR.