Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[librariesio] Fixed error handling #1964

Merged
merged 2 commits into from
Aug 24, 2018
Merged

[librariesio] Fixed error handling #1964

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a8eef3
Fixed error handling
PyvesB Aug 23, 2018
743de19
Merge branch 'master' into librariesio-error
paulmelnikow Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/librariesio/librariesio-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class LibrariesIoBase extends BaseJsonService {
const json = await this._requestJson({
schema: packageOrRepoSchema,
url: `https://libraries.io/api/${platform}/${packageName}`,
notFoundMessage: 'package not found',
errorMessages: { 404: 'package not found' },
})
const isPackage = Boolean(json.platform)
if (isPackage && !allowPackages) {
Expand Down