[librariesio] Fixed error handling #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyvesB
added
bug
paulmelnikow
approved these changes
Aug 23, 2018
|
Oops! Thanks for fixing that! |
|
I can't manage to get all the tests passing in one go. A lot of them randomly time out. The Libraries.io service seems to be acting up, when hitting the API directly the responses sometimes take many seconds to come back. This is hopefully a temporary issue, let's try running the tests later on. |
|
Yea, the API is not very fast. I feel like we should put some caching in front of it, and/or look for replacements… |
|
Everything passed in one go this time, with both Node environments. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1959. The bug managed to slip in between the merger of #1895 and #1888!