Rewrite [uptimerobot] #1891
Merged
Rewrite [uptimerobot] #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
Sounds good. Want to give that a second 👍 and then merge it? |
chris48s
reviewed
Aug 12, 2018
|
|
||
| module.exports = class UptimeRobotBase extends BaseJsonService { | ||
| static get category() { | ||
| return 'other' |
There was a problem hiding this comment.
Can we just return 'monitoring' here and remove the category() functions from the child classes?
There was a problem hiding this comment.
Ha! Yes. It's funny, I went looking for the category and couldn't find it. I was looking in the wrong place :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1890 and the diff will clean up once that goes in.