Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split BaseService and BaseJsonService into separate modules; tested on [clojars gem npm appveyor cdnjs] #1889

Merged
merged 2 commits into from
Aug 11, 2018
Merged

Split BaseService and BaseJsonService into separate modules; tested on [clojars gem npm appveyor cdnjs] #1889

merged 2 commits into from
Aug 11, 2018

Conversation

paulmelnikow
Copy link
Member

There’s a lot of behavior here, and going to be even more, so I think it makes sense to split these up as I’ve done with the tests.

@paulmelnikow
Split BaseService and BaseJsonService into separate modules
7f481a4 
There’s a lot of behavior here, and going to be even more, so I think it makes sense to split these up as I’ve done with the tests.
@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Aug 10, 2018
@shields-ci
Copy link

Warnings
⚠️

This PR modified service code for apm but not its test code. That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for appveyor but not its test code. That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for cdnjs but not its test code. That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for clojars but not its test code. That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for gem but not its test code. That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for npm but not its test code. That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for time but not its test code. That's okay so long as it's refactoring existing code.
Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow changed the title Split BaseService and BaseJsonService into separate modules; tested on [clojars gem npm appveyor time cdnjs] Split BaseService and BaseJsonService into separate modules; tested on [clojars gem npm appveyor cdnjs] Aug 10, 2018
@paulmelnikow
Copy link
Member Author

Some PRs may need to be updated after this goes in, e.g. #1891.

@RedSparr0w
Copy link
Member

Definitely agree this is a big enough service that it warrants its own file.
👍

@paulmelnikow paulmelnikow merged commit db4bffb into badges:master Aug 11, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status:

@paulmelnikow paulmelnikow deleted the split-base-service branch August 11, 2018 14:43
@snyk-bot snyk-bot mentioned this pull request Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedSparr0w RedSparr0w RedSparr0w approved these changes

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmelnikow @shields-ci @RedSparr0w @PyvesB