Minor tweaks in [github] auth code

lib/token-pool.js

@@ -219,6 +219,12 @@ class TokenPool {
     this.fifoQueue.forEach(visit);
     this.priorityQueue.forEach(visit);
   }
+
+  allValidTokenIds() {
+    const result = [];
+    this.forEach(({ id }) => result.push(id));
+    return result;
+  }
 }
 
 module.exports = {

lib/token-provider.js

@@ -57,14 +57,9 @@ class PoolingTokenProvider {
   }
 
   // Return an array of token strings.
-  toNative () {
-    const result = [];
+  toNative() {
+    return this.tokenPool.allValidTokenIds();
 
-    this.tokenPool.forEach(token => {
-      result.push(token.id);
-    });
-
-    return result;
   }
 }
 

lib/token-provider.spec.js

@@ -2,7 +2,7 @@
 
 const assert = require('assert');
 const { PoolingTokenProvider } = require('./token-provider');
-const isValidGithubToken = require('./github-auth/is-valid-token')
+const isValidGithubToken = require('../services/github/auth/is-valid-token')
 
 describe('The token provider', function () {
   describe('toNative', function () {

server.js

@@ -3406,10 +3406,10 @@ cache(function(data, match, sendBadge, request) {
   var allReleases = match[2];
   var format = match[3];
   let apiUrl = `/repos/${userRepo}/releases`;
-  var badgeData = getBadgeData('release', data);
   if (allReleases === undefined) {
     apiUrl = apiUrl + '/latest';
   }
+  var badgeData = getBadgeData('release', data);
   if (badgeData.template === 'social') {
     badgeData.logo = getLogo('github', data);
   }