Minor tweaks in [github] auth code

lib/token-pool.js

@@ -234,6 +234,12 @@ class TokenPool {
     this.fifoQueue.forEach(visit)
     this.priorityQueue.forEach(visit)
   }
+
+  allValidTokenIds() {
+    const result = []
+    this.forEach(({ id }) => result.push(id))
+    return result
+  }
 }
 
 module.exports = {

lib/token-pool.spec.js

@@ -22,6 +22,10 @@ describe('The token pool', function() {
     ids.forEach(id => tokenPool.add(id))
   })
 
+  it('allValidTokenIds() should return the full list', function() {
+    expect(tokenPool.allValidTokenIds()).to.deep.equal(ids)
+  })
+
   it('should yield the expected tokens', function() {
     ids.forEach(id =>
       times(batchSize, () => expect(tokenPool.next().id).to.equal(id))

lib/token-provider.js

@@ -57,13 +57,7 @@ class PoolingTokenProvider {
 
   // Return an array of token strings.
   toNative() {
-    const result = []
-
-    this.tokenPool.forEach(token => {
-      result.push(token.id)
-    })
-
-    return result
+    return this.tokenPool.allValidTokenIds()
   }
 }
 

lib/token-provider.spec.js

@@ -2,7 +2,7 @@
 
 const assert = require('assert')
 const { PoolingTokenProvider } = require('./token-provider')
-const isValidGithubToken = require('./github-auth/is-valid-token')
+const isValidGithubToken = require('../services/github/auth/is-valid-token')
 
 describe('The token provider', function() {
   describe('toNative', function() {

server.js

@@ -3190,10 +3190,10 @@ cache(function(data, match, sendBadge, request) {
   var allReleases = match[2];
   var format = match[3];
   let apiUrl = `/repos/${userRepo}/releases`;
-  var badgeData = getBadgeData('release', data);
   if (allReleases === undefined) {
     apiUrl = apiUrl + '/latest';
   }
+  var badgeData = getBadgeData('release', data);
   if (badgeData.template === 'social') {
     badgeData.logo = getLogo('github', data);
   }