On [Github] issues badge, add quotes around multi-word labels

[platan]

Now "good first issue" badges in README works properly.

[paulmelnikow]

Thanks. I like the look of the label with quotes!

I mentioned in d29bdea that these badges were dependent on #1135 which has been merged but is waiting to be deployed. It's working correctly on the staging server:

https://shields-staging.herokuapp.com/github/issues/badges/shields/good%20first%20issue.svg

[platan]

Great to see them working. I've missed that change.

[paulmelnikow]

We should merge your issue -> pull request alt text change on L73.

Would you like to update the badge code to insert quotes into the badge title, when given a multi-word issue? In other words, to change good first issue issues to “good first issue” issues.

[tooomm]

but is waiting to be deployed

Is there a new deploy scheduled? Or do you plan on merging specific PR's first?

[platan]

Currently there are 283 open issues with "App - Cockatrice" label and 0 with "Easy Change" label.

[paulmelnikow]

Is there a new deploy scheduled?

It's usually within 1–3 weeks. Thaddée is the only one with access, though we're aiming to add me sometime next month. You can monitor the gh-pages branch which will update when the deploy happens.

Or do you plan on merging specific PR's first?

Master is always ready to deploy, at least that's my aim.

[paulmelnikow]

Ran github tests locally with #1114. Two unrelated timeouts:

  1) Github Commits since by latest release
	[ GET http://localhost:1111/github/commits-since/microsoft/typescript/latest.json ]:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.


  2) Github (pre-)Release
	[ GET http://localhost:1111/github/release/photonstorm/phaser/all.json ]:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

[paulmelnikow]

Thanks! This is sweet! 🍰

[platan]

Thanks!