[GitHub] Issue and pull request detail and check state #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
added
developer-experience
This was referenced Sep 29, 2017
paulmelnikow
commented
Sep 29, 2017
service-tests/github.js
Outdated
| .expectJSONTypes(Joi.object().keys({ name: 'updated', value: validDateString })); | ||
|
|
||
| t.create('github pull request check state') | ||
| .get('/pulls/checks/s/badges/shields/1110.json') |
There was a problem hiding this comment.
We could make this /status/s/pulls/badges/shields/1110.json which might be nicer for adding check state of branches + commits, as in #774.
Daniel15
reviewed
Oct 1, 2017
server.js
Outdated
| // GitHub issue detail integration. | ||
| camp.route(/^\/github\/(?:issues|pulls)\/detail\/(s|title|u|label|comments|age|last-update)\/([^\/]+)\/([^\/]+)\/(\d+)\.(svg|png|gif|jpg|json)$/, | ||
| cache((queryParams, match, sendBadge, request) => { | ||
| const stateColor = s => ({ open: '2cbe4e', closed: 'cb2431', merged: '6f42c1' }[s]); |
There was a problem hiding this comment.
This is going to re-define the function ever time this route is called, which is not really necessary as it's entirely static. Instead, pull this function out and make it a regular function in this file (or in one of the utility modules).
Daniel15
approved these changes
Oct 1, 2017
# Conflicts: # server.js
# Conflicts: # package.json # service-tests/github.js
|
Service tests passing locally with this patch that works around a bug in our logic for token rate limit handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds badges for Github issues and pull requests. You can display the state, title, username, number of comments, age, time since last update, and state of checks.
Blocked on #1112 (see FIXMEs).
Provides an endpoint the Shields CI can use to fetch PR titles for #979 and resolves #1011.