Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hello World job as the previous version seems to be outdated. #4857

Merged
merged 2 commits into from
Feb 23, 2025
Merged

Update Hello World job as the previous version seems to be outdated. #4857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d64c438
Update Hello World job as the previous version seems to be outdated.
haixuanTao Feb 20, 2025
053fef1
Merge branch 'main' into patch-1
wdbaruni Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ curl -sL https://get.bacalhau.org/install.sh | bash
Submit a "Hello World" job

```bash
bacalhau docker run ubuntu echo Hello World
bacalhau docker run \
-c API.Host=bootstrap.production.bacalhau.org \
--wait \
docker run \
docker.io/bacalhauproject/hello-world:latest
Comment on lines +73 to +77
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Verify the updated Hello World command syntax.
The new command improves functionality by configuring the API host and waiting for the job. However, please verify that the repeated use of docker run is intentional (i.e. after the --wait flag) and that it correctly invokes the desired Docker image. If this repetition is a mistake, consider removing the extra docker run for clarity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @haixuanTao, Thank you for your first contribution. A simpler command might be:

bacalhau --api-host=bootstrap.demo.bacalhau.org docker run ubuntu echo Hello World

Though we should clarify that this will run a job on the demo network

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I took this from the documentation of the website.

I think it would be better if both are aligned.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%. We are currently revamping our docs and all should be fixed and up to date

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the PR

```

Download your result
Expand Down
Loading