-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hello World job as the previous version seems to be outdated. #4857
Conversation
WalkthroughThe changes update the "Getting started - Bacalhau in 1 minute" section in the README. The original command for running a "Hello World" Docker job is replaced by one that includes additional parameters: it explicitly sets the API host, adds a Changes
Sequence Diagram(s)Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bacalhau docker run \ | ||
-c API.Host=bootstrap.production.bacalhau.org \ | ||
--wait \ | ||
docker run \ | ||
docker.io/bacalhauproject/hello-world:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Verify the updated Hello World command syntax.
The new command improves functionality by configuring the API host and waiting for the job. However, please verify that the repeated use of docker run
is intentional (i.e. after the --wait
flag) and that it correctly invokes the desired Docker image. If this repetition is a mistake, consider removing the extra docker run
for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @haixuanTao, Thank you for your first contribution. A simpler command might be:
bacalhau --api-host=bootstrap.demo.bacalhau.org docker run ubuntu echo Hello World
Though we should clarify that this will run a job on the demo network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I took this from the documentation of the website.
I think it would be better if both are aligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100%. We are currently revamping our docs and all should be fixed and up to date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved the PR
The previous README getting used to give me an error.
I think I corrected it
Summary by CodeRabbit