fix(Scripts/Halion): Halion freeze against "Feign Death" hunters

[EricksOliveira]

Halion's reset now works correctly under all tested conditions.

Prevents encounter exploits from players using Feign Death to bypass the reset.

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• [x ] Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes Ruby Sanctum - Halion freeze against "dead" hunters #3359

SOURCE:

The changes have been validated through:

• [x ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• [x ] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• [x ] Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

This update fixes an issue with Halion's behavior during the encounter reset logic. The issue occurred when players used the Feign Death (ID: 5384) ability, preventing the boss from entering evasion mode correctly, causing a crash during the encounter reset.

• [x ] This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. Enter the Ruby Sanctum Raid, reach Boss Halion.
2. Start the fight with 1 Hunter inside the circle and another character outside the circle.
3. Use Hunter's Feign Death spell and watch Halion's reset happen as expected.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Nyeriah]

magic numbers
also, Script/Instance and not Script/Boss

[EricksOliveira]

magic numbers also, Script/Instance and not Script/Boss

Ok. Sorry