Integrate SmartFormat v3.2.1 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate project MailMergeLib * MailMergeMessage_Exceptions: Allow null for inner Exception * Migrate project MailMergeLib.Tests
* New method to get a free TCP port * SslProtocols: let operating system select the best
* Remove unnecessary OneTimeSetup and FixtureTearDown
* Add method trying to bind an available port * Removed console message for CanBindPort(int port)
No breaking MailMergeLib API changes from version 5.9.10 However SmartFormat v3 brings breaking changes to v2 (e.g. for formatter names, where name "template" changed to "t" and other) * Update MailSmartFormatter to load at least the same SmartFormat extensions as before * Code updates for breaking changes from SmartFormat v2.7.3 to v3.2.1 * MailMergeMessage: A new MailSmartFormatter instance is created after properties of SmartFormatterConfig are changed. This is because SmartFormatter does not allow for changes to the settings, after the instance is created * Further fixes for NRT * Minor style refactoring * Fix some typos
* Update YAXLib to v4.1.0 * Update AngeSharp to v1.0.4 * Update Microsoft.NET.Test.Sdk to v17.6.3" * Unit test run with net462, netcoreapp3.1 and net6.0 * Disable unit tests console output * Run unit test for linux under netstandard2.1
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 94.40% 94.30% -0.11%
==========================================
Files 39 39
Lines 1949 1967 +18
==========================================
+ Hits 1840 1855 +15
- Misses 109 112 +3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate
SmartFormat.NET v2.7.3 to v3.2.1Heads up
This version is API and source compatible with prior 5.x versions.
In v5.11 the referenced package for
SmartFormat.NETis updated from v2.7.3 to v3.2.1. This new major version ofSmartFormat.NETincurs breaking changes. MailMergeLib manages breaking API changes under the hood. Other breaking changes are related to using SmartFormat formatter extensions in placeholders:"{Fruit:cond:Apple|Pie|Orange|Banana|No fruit}", where the rendered string depends on theFruitvariable, urgently have a look at https://github.com/axuno/SmartFormat/wiki/Migration#2-formatter-differences-from-v2-to-v3 .Required modifications are not extensive, but unavoidable.SmartFormat v3has many advantages:See more details here: https://github.com/axuno/SmartFormat/wiki/Why-Migrate
Details
SmartFormat.NETto v3.2.1 with at least the same extensions enabled as in priorMailMergeLib5.x versions