Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with MailKit v3.0 #23

Closed
Scantheus opened this issue Jan 7, 2022 · 3 comments · Fixed by #38
Closed

Not compatible with MailKit v3.0 #23

Scantheus opened this issue Jan 7, 2022 · 3 comments · Fixed by #38
Assignees

Comments

@Scantheus
Copy link

After updating my nugets in an application that I've been using MailMergeLib for months without issue, it now gives me this exception error (see attached image).

Another application that uses MailMergeLib still works because I haven't updated nugets.

Both use lastest MailMergeLib v5.7.1 but the one that breaks uses MailKit v3.0 instead of MailKit v2.15.

It looks like MailKit 3.0 introduced a breaking change.

image

@Scantheus
Copy link
Author

Looking through MailKit change history, the return value of the Send method was changed from void to string 8 months ago.
Mailkit v3.0 was release about a month ago.
MailMergeLib dependency in nuget accepts MailKit version 2.4 or higher.

@axunonb axunonb self-assigned this Jan 7, 2022
@axunonb axunonb added the bug label Jan 7, 2022
@axunonb
Copy link
Member

axunonb commented Jan 7, 2022

Thanks for the hint, gotta fix this.
Btw. MailMergeLib will get a major update after SmartFormat v3.0 will be released. I'm just working on that. Are you making use it's formatting capabilities?

@axunonb axunonb added enhancement and removed bug labels Jan 7, 2022
@axunonb
Copy link
Member

axunonb commented Feb 4, 2022

Fixed with version 5.8.0

@axunonb axunonb closed this as completed Feb 4, 2022
axunonb added a commit that referenced this issue Jun 29, 2023
* Update of SmartFormat.NET to v3.2.1 with at least the same extensions enabled as in prior MailMergeLib 5.x versions
* Add NET6.0 as a target framework, reducing number of dependencies
* Update YAXLib to v4.1.0
* Update AngeSharp to v1.0.4
* Update Microsoft.NET.Test.Sdk to v17.6.3"
* Unit test run with net462, netcoreapp3.1 and net6.0
* Disable unit tests console output
* After installation is completed, the above "Heads up" message is displayed
* Add Sandcastle Help File Builder project folder
* Resolves #23
* Enable Nullable Reference Types (NRT) (#30)
* Removed obsolete SmartObjects as data source (#31)
* Change setup for SMTP Integration tests (#32)
* New method to get a free TCP port
* SslProtocols: let operating system select the best
* Improved Sender integration tests
* Fix: SmtpSever trying to use an unpermitted port (#33)
* Add method trying to bind an available port
* Removed console message for CanBindPort(int port)
* Update MailSmartFormatter to load at least the same SmartFormat extensions as before
* MailMergeMessage: A new MailSmartFormatter instance is created after properties of SmartFormatterConfig are changed. This is because SmartFormatter does not allow for changes to the settings, after the instance is created
* Run unit test for linux under netstandard2.1
* Code refactoring from NET6.0 analytics
* Update readme and license files
* SmartFormatterConfig change retains existing SmartSettings
* Disable warnings for unused private variables in MessageConfig
* Add Sandcastle Help File Builder project folder

No breaking MailMergeLib API changes from version 5.9.10
However SmartFormat v3 brings breaking changes compared to v2 (e.g. for formatter names, where name "template" changed to "t" and others)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants