forked from jaegertracing/jaeger
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Skip linting on Go tip (jaegertracing#4338)
golangci-lint doesn't seem to like running against Go tip: https://github.com/jaegertracing/jaeger/actions/runs/4517523436/jobs/7956780871#step:7:5416 The errors are actually invalid, since `typecheck` is not a linter, it flags compile errors, but unit tests run fine. Signed-off-by: Yuri Shkuro <[email protected]>
- Loading branch information
1 parent
17f34b7
commit 4f231b6
Showing
3 changed files
with
8 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,3 +35,6 @@ jobs: | |
|
|
||
| - name: Run unit tests | ||
| run: make test-ci | ||
|
|
||
| - name: Lint | ||
| run: echo skip linting on Go tip | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,3 +46,6 @@ jobs: | |
| flags: unittests | ||
| fail_ci_if_error: true | ||
| token: ${{ env.CODECOV_TOKEN }} | ||
|
|
||
| - name: Lint | ||
| run: make lint | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -394,14 +394,14 @@ draft-release: | |
| .PHONY: install-tools | ||
| install-tools: | ||
| $(GO) install github.com/vektra/mockery/[email protected] | ||
| $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2 | ||
| $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.1 | ||
| $(GO) install mvdan.cc/gofumpt@latest | ||
|
|
||
| .PHONY: install-ci | ||
| install-ci: install-tools | ||
|
|
||
| .PHONY: test-ci | ||
| test-ci: build-examples cover lint | ||
| test-ci: build-examples cover | ||
|
|
||
| .PHONY: thrift | ||
| thrift: idl/thrift/jaeger.thrift thrift-image | ||
|
|
||