Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade Dockerfile to go 1.19 #580

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

ginglis13
Copy link
Contributor

@ginglis13 ginglis13 commented Aug 2, 2023

Issue #, if available:

Fixes #579

Description of changes:

outdated version of Go in Dockerfile resulted in build failures. Add step in CI to build in Dockerfile for future regressions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ginglis13 ginglis13 requested review from a team as code owners August 2, 2023 16:48
@ginglis13 ginglis13 force-pushed the update-dockerfile-go branch 3 times, most recently from e0b46ac to a09cafc Compare August 2, 2023 17:14
Copy link
Contributor

@swagatbora90 swagatbora90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ginglis13 ginglis13 force-pushed the update-dockerfile-go branch from a09cafc to 71ce3b1 Compare August 2, 2023 21:26
@ginglis13 ginglis13 merged commit 5c087f3 into awslabs:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest commit on Aug 1st seems to break build
2 participants