Skip to content

Commit 5c087f3

Browse files
authored
Merge pull request #580 from ginglis13/update-dockerfile-go
fix: upgrade Dockerfile to go 1.19
2 parents 44fa0cd + 71ce3b1 commit 5c087f3

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.github/workflows/build.yaml

+7-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,13 @@ jobs:
2727
with:
2828
go-version: ${{ matrix.go }}
2929
- run: make get-deps
30-
if: ${{ matrix.go >= '1.17' }}
30+
if: ${{ matrix.go >= '1.19' }}
31+
32+
# test Dockerfile build on Linux. macOS runners do not ship with Docker
33+
# installed by default whereas Ubuntu runners do.
34+
- name: Build in Dockerfile
35+
run: make docker
36+
if: ${{ matrix.os == 'ubuntu-22.04' }}
3137

3238
# Apple Silicon is not supported by Go < 1.16.
3339
# https://go.dev/blog/go1.16

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
# ANY KIND, either express or implied. See the License for the specific
1212
# language governing permissions and limitations under the License.
1313

14-
FROM golang:1.15
14+
FROM golang:1.19
1515

1616
WORKDIR /go/src/github.com/awslabs/amazon-ecr-credential-helper
1717

0 commit comments

Comments
 (0)