Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
The s2n-tls release is currently blocked due to a fuzz test failure. This is likely caused by recent changes to runFuzzTest.sh, which introduced incompatibilities with the Make build in the Omnibus job.
Failed job: Link to CodeBuild
Instead of fixing the Make build, we can replace it with a CMake-based fuzz build, as introduced in #4743
Description of changes:
buildspec_fuzz.yml
into two files:buildspec_fuzz_batch.yml
to manage the batch job with environment variables for each job.buildspec_fuzz.yml
to handle the actual CMake build commands.-DCMAKE_PREFIX_PATH=$LIBCRYPTO_ROOT
flag was not loading the intended libcrypto correctly, and this PR addresses that issue.Call-outs:
This PR requires changes to both the
s2nFuzzBatch
ands2nOmnibus
jobs:s2nFuzzBatch
: Update the buildspec file fromcodebuild/spec/buildspec_fuzz.yml
tocodebuild/spec/buildspec_fuzz_batch.yml
.s2nOmnibus
: In the buildspec, replace the following:with:
Testing:
Tested changes in this PR by overriding CodeBuild jobs:
Omnibus job ran with the modified buildspec definition: Link to CodeBuild
(Note that the old fuzz tests have been removed, and the new
s2nFuzzerAWSLC
ands2nFuzzerOSSL_3_0
jobs have been added to the batch list.)s2nFuzzBatch job using
buildspec_fuzz_batch.yml
: Link to CodeBuildBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.