-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: enable fuzz test build with cmake #4743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- suppress cast-qual warning
- change link option to public - move libfuzzer path definition to buildspec - use target_include_directories instead - comment to explain LD_PRELOAD issue - address nits
dougch
reviewed
Sep 4, 2024
- remove -O0 and -fvisibility=default - remove make specific logic in buildspec
- use ctest to run fuzz tests - remove unnecessary compiler options
jmayclin
approved these changes
Sep 5, 2024
- change compute type - add comment explaining cmake arg - revert inline changes to better handle merge conflict
dougch
reviewed
Sep 5, 2024
- fix cmake command for codebuild.sh - new message to indicate when fuzz is enabled
dougch
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Currently, fuzz tests are only built with the Make build system. This change allows us to build fuzz tests using CMake as part of our ongoing effort to migrate from Make to CMake. The primary goal of this PR is to replicate the current functionality provided by Make in CMake. Additional improvements to fuzzing are planned and are described in the call-outs section.
Description of changes:
This change enables building fuzz tests with CMake. The commands to build and run fuzz tests:
Detailed description of changes:
CMakeLists.txt
cmake --build build --target run_fuzz
after compilingcodebuild/bin/s2n_codebuild.sh
codebuild/spec/buildspec_fuzz.yml
tests/fuzz/runFuzzTest.sh
utils/s2n_result.c & utils/s2n_result.h
Call-outs:
Waiting for PR #4739 to be merged to fully apply the s2n_result inline change.
There are several follow-up tasks for general fuzzing improvements that needs to be done. The tasks are being tracked at #4748
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.