Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AWSNodeTemplate CRD for AWS specific config #1822

Merged
merged 4 commits into from
May 19, 2022

Conversation

suket22
Copy link
Contributor

@suket22 suket22 commented May 18, 2022

1. Issue, if available:
N/A

2. Description of changes:
As follow-up from #1720 this attempts to create a dedicated CRD for the AWSProvider where we will house fields like UserData, ImageId and so on.

3. How was this change tested?
Installed the CRD and verified that the webhooks were working as well.

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 3fb4037
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62856dc5719ffe00093806cc

@suket22 suket22 marked this pull request as ready for review May 18, 2022 00:44
@suket22 suket22 requested a review from a team as a code owner May 18, 2022 00:44
@suket22 suket22 requested a review from bwagner5 May 18, 2022 00:44
spring1843
spring1843 previously approved these changes May 18, 2022
Copy link
Contributor

@spring1843 spring1843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/snapshot

@suket22 suket22 changed the title Adds AWSProvider CRD for AWS specific config Adds AWSNodeTemplate CRD for AWS specific config May 18, 2022
@suket22 suket22 merged commit 7280acc into aws:main May 19, 2022
@suket22 suket22 mentioned this pull request May 23, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants