-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for customUserData with Bottlerocket #1720
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this, but the changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add docs with an example of a simple bottlerocket config in the provisioner?
And can you add a test too?
I intentionally left the docs out. I was thinking of adding them once I've got support for both AMI families rather than just one, but can add them now. I'll add a few tests 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few doc nits, but otherwise lgtm!
Co-authored-by: Brandon Wagner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
1. Issue, if available:
N/A
2. Description of changes:
This change only adds support for customUserData with Bottlerocket AMIFamily. It follows what's defined in this doc for the most part. The one main change is that I'm no longer merging labels / taints from the custom userData but rather overwriting them completely. This is because of what we discovered here regarding kubelet not merging in other labels. As long as Karpenter creates the node object itself, there's no point merging in labels / taints etc.
3. How was this change tested?
4. Does this change impact docs?
I'm thinking of only adding docs once AL2 support is here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.