Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customUserData with Bottlerocket #1720

Merged
merged 23 commits into from
May 25, 2022
Merged

Conversation

suket22
Copy link
Contributor

@suket22 suket22 commented Apr 25, 2022

1. Issue, if available:
N/A

2. Description of changes:
This change only adds support for customUserData with Bottlerocket AMIFamily. It follows what's defined in this doc for the most part. The one main change is that I'm no longer merging labels / taints from the custom userData but rather overwriting them completely. This is because of what we discovered here regarding kubelet not merging in other labels. As long as Karpenter creates the node object itself, there's no point merging in labels / taints etc.

3. How was this change tested?

  • I've tested this locally - ran through both the provider level validation checks.
  • The bootstrap logic isn't unit tested but I've been testing it out locally and my nodes are joining the cluster. I haven't tried the full extent of all BR settings but most that I've tried have worked.

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

I'm thinking of only adding docs once AL2 support is here.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@suket22 suket22 requested a review from a team as a code owner April 25, 2022 16:38
@suket22 suket22 requested a review from tzneal April 25, 2022 16:38
@netlify
Copy link

netlify bot commented Apr 25, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 9bdb35f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/628eabb79ffc9100080eabae
😎 Deploy Preview https://deploy-preview-1720--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tzneal
tzneal previously approved these changes Apr 26, 2022
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this, but the changes LGTM

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add docs with an example of a simple bottlerocket config in the provisioner?

And can you add a test too?

@suket22
Copy link
Contributor Author

suket22 commented Apr 28, 2022

can you add docs with an example of a simple bottlerocket config in the provisioner?

And can you add a test too?

I intentionally left the docs out. I was thinking of adding them once I've got support for both AMI families rather than just one, but can add them now.

I'll add a few tests 👍

@suket22 suket22 marked this pull request as draft May 3, 2022 16:32
@suket22 suket22 marked this pull request as ready for review May 3, 2022 18:26
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few doc nits, but otherwise lgtm!

@suket22 suket22 requested review from bwagner5 and tzneal May 9, 2022 20:45
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@suket22 suket22 marked this pull request as draft May 12, 2022 16:58
@suket22 suket22 marked this pull request as ready for review May 12, 2022 22:24
tzneal
tzneal previously approved these changes May 16, 2022
@suket22 suket22 marked this pull request as draft May 20, 2022 05:58
@suket22 suket22 marked this pull request as ready for review May 20, 2022 18:34
@suket22 suket22 requested a review from bwagner5 May 23, 2022 15:37
@suket22 suket22 dismissed bwagner5’s stale review May 23, 2022 18:26

Docs and tests were added.

@suket22 suket22 requested review from ellistarn and tzneal May 25, 2022 17:08
@suket22 suket22 merged commit 2a07ac1 into aws:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants