Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsii): experimental --strip-deprecated with file #3085

Merged
merged 5 commits into from
Oct 22, 2021

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Oct 21, 2021

Introduce an optional new parameter for the --strip-deprecated feature, which
allows constrains the feature to only strip deprecated API elements present in
an allowlist file. This can be used to preserve some deprecated API elements
while stripping others.

Feedback welcome on the nomenclature throughout. :)

related aws/aws-cdk#16566


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Introduce an optional new parameter for the `--strip-deprecated` feature, which
allows constrains the feature to only strip deprecated API elements present in
an allowlist file. This can be used to preserve some deprecated API elements
while stripping others.

Feedback welcome on the nomenclature throughout. :)
@njlynch njlynch requested a review from a team October 21, 2021 12:07
@njlynch njlynch self-assigned this Oct 21, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 21, 2021
@njlynch
Copy link
Contributor Author

njlynch commented Oct 22, 2021

Latest update also changes the separator between types and members to be a # instead of a . (e.g., SomeClass#someProp vs SomeClass.someProp. Feedback welcome.

@njlynch njlynch changed the title feat(jsii): experimental --strip-deprecated-allowlist-file feature feat(jsii): experimental --strip-deprecated with file Oct 22, 2021
@njlynch njlynch merged commit e5ba807 into main Oct 22, 2021
@njlynch njlynch deleted the njlynch/strip-deprecated-allowlist branch October 22, 2021 15:22
njlynch added a commit to aws/aws-cdk that referenced this pull request Nov 1, 2021
This is a continuation (and the final piece!) of
aws/jsii#3085 and
#17120.

Changes cdk-build to use the fixed deprecated list, rather than stripping all
deprecated elements. This will enable us to deprecate new elements going forward
without stripping them from v2 and breaking customers.

closes #16566
mergify bot pushed a commit to aws/aws-cdk that referenced this pull request Nov 1, 2021
This is a continuation (and the final piece!) of aws/jsii#3085 and #17120.

Changes cdk-build to use the fixed deprecated list, rather than stripping all
deprecated elements. This will enable us to deprecate new elements going forward
without stripping them from v2 and breaking customers.

closes #16566


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
This is a continuation (and the final piece!) of aws/jsii#3085 and aws#17120.

Changes cdk-build to use the fixed deprecated list, rather than stripping all
deprecated elements. This will enable us to deprecate new elements going forward
without stripping them from v2 and breaking customers.

closes aws#16566


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants