-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jsii): experimental --strip-deprecated with file #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an optional new parameter for the `--strip-deprecated` feature, which allows constrains the feature to only strip deprecated API elements present in an allowlist file. This can be used to preserve some deprecated API elements while stripping others. Feedback welcome on the nomenclature throughout. :)
Latest update also changes the separator between types and members to be a |
rix0rrr
approved these changes
Oct 22, 2021
njlynch
added a commit
to aws/aws-cdk
that referenced
this pull request
Nov 1, 2021
This is a continuation (and the final piece!) of aws/jsii#3085 and #17120. Changes cdk-build to use the fixed deprecated list, rather than stripping all deprecated elements. This will enable us to deprecate new elements going forward without stripping them from v2 and breaking customers. closes #16566
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Nov 1, 2021
This is a continuation (and the final piece!) of aws/jsii#3085 and #17120. Changes cdk-build to use the fixed deprecated list, rather than stripping all deprecated elements. This will enable us to deprecate new elements going forward without stripping them from v2 and breaking customers. closes #16566 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
This is a continuation (and the final piece!) of aws/jsii#3085 and aws#17120. Changes cdk-build to use the fixed deprecated list, rather than stripping all deprecated elements. This will enable us to deprecate new elements going forward without stripping them from v2 and breaking customers. closes aws#16566 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an optional new parameter for the
--strip-deprecated
feature, whichallows constrains the feature to only strip deprecated API elements present in
an allowlist file. This can be used to preserve some deprecated API elements
while stripping others.
Feedback welcome on the nomenclature throughout. :)
related aws/aws-cdk#16566
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.