Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-node-termination-handler fargate affinity #199

Closed
wants to merge 2 commits into from

Conversation

limed
Copy link
Contributor

@limed limed commented Jul 7, 2020

Issue #198, if available:

Description of changes:

  • Add affinity to aws-node-termination-handler to not schedule on a
    fargate node

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5
Copy link
Collaborator

bwagner5 commented Jul 8, 2020

Thanks for contributing!! Would you mind opening this PR on the aws-node-termination-handler repo. We commit there first and then a maintainer will sync over to eks-charts so that all of the e2e tests are run and latest changes are in-sync.

The helm chart is here: https://github.com/aws/aws-node-termination-handler/tree/master/config/helm/aws-node-termination-handler

@limed
Copy link
Contributor Author

limed commented Jul 8, 2020

Thanks for contributing!! Would you mind opening this PR on the aws-node-termination-handler repo. We commit there first and then a maintainer will sync over to eks-charts so that all of the e2e tests are run and latest changes are in-sync.

The helm chart is here: https://github.com/aws/aws-node-termination-handler/tree/master/config/helm/aws-node-termination-handler

@bwagner5 Done, PR aws/aws-node-termination-handler#191 created

@bwagner5
Copy link
Collaborator

bwagner5 commented Jul 8, 2020

thanks!

@bwagner5 bwagner5 closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants