Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't schedule aws-node-termination-handler on fargate nodes #191

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

limed
Copy link
Contributor

@limed limed commented Jul 8, 2020

Issue aws/eks-charts#198, if available:

Description of changes:

  • Add affinity to aws-node-termination-handler to not schedule on a
    fargate node

Per aws/eks-charts#199 (comment) I'm creating a PR on this repo instead.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@limed limed changed the title Issue #, if available: Don't schedule aws-node-termination-handler on fargate nodes Jul 8, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   81.26%   81.26%           
=======================================
  Files          10       10           
  Lines         774      774           
=======================================
  Hits          629      629           
  Misses        129      129           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7d811...a4a5468. Read the comment docs.

@bwagner5 bwagner5 self-requested a review July 8, 2020 16:18
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bwagner5 bwagner5 merged commit e769d9e into aws:master Jul 8, 2020
@limed limed deleted the limed/fargate-exclude branch July 10, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants