feat: local files generated by svc and pipeline are not deleted #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoManyHs
reviewed
Jun 19, 2020
There was a problem hiding this comment.
LGTM! Just a few small things -- also do you think it'd be helpful to modify the long description of the various delete commands to mention that the local files will be persisted?
Also, would you mind adding some manual output (unless the e2e tests cover this). Thanks!!
efekarakus
reviewed
Jun 19, 2020
efekarakus
reviewed
Jun 19, 2020
iamhopaul123
approved these changes
Jun 19, 2020
iamhopaul123
added
the
do-not-merge
efekarakus
approved these changes
Jun 22, 2020
efekarakus
removed
the
do-not-merge
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2020
Added e2e tests. Had to reinitialize app and svc inside the test files since my tests revolves around not deleting local files (expect .workspace) when running `app delete` and `svc delete`. Addresses #1034 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This was referenced Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1031, #800
Summary
svc deletepipeline deleteapp deleteBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
TODO:
e2e testing