Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not deleting local files flag design #1031

Closed
seongm-1 opened this issue Jun 18, 2020 · 1 comment
Closed

Not deleting local files flag design #1031

seongm-1 opened this issue Jun 18, 2020 · 1 comment
Labels
type/design Issues that are design proposals.

Comments

@seongm-1
Copy link
Contributor

seongm-1 commented Jun 18, 2020

Overview

Related #800. The CLI current behavior is that it deletes the local files it generates. We want to change this default behavior but still possibly provide the option to delete the files if the user wants.

Design Proposal

Default Behavior

We will change the default behavior to not delete the local files generated by the CLI when the user runs either svc delete or pipeline delete

If we want to still provide the option to delete the generated local files then we can propose a flag option such as svc delete --files to provide the current behavior.

If we do not provide this option, then the user can simply delete the folder.

@seongm-1 seongm-1 added the type/design Issues that are design proposals. label Jun 18, 2020
mergify bot pushed a commit that referenced this issue Jun 22, 2020
Addresses #1031, #800

## Summary

`svc delete`
* will not delete manifest.yml
* will not delete addons/

`pipeline delete`
* will not delete pipeline.yml
* buildspec.yml was already not deleted 

`app delete`
* will not delete the files mentioned above but only delete .workspace file


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

TODO:
e2e testing
@efekarakus
Copy link
Contributor

Released with #1034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/design Issues that are design proposals.
Projects
None yet
Development

No branches or pull requests

2 participants