Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for go dep and go modules #90

Merged
merged 4 commits into from
Mar 13, 2019

Conversation

chrisradek
Copy link
Contributor

Issue #, if available:
#73

Description of changes:
This change adds support for go dep and go modules. It also updates travis to use dep in go versions 1.9 and 1.10, while using go modules in go versions 1.11 and 1.12 (and tip).

I did not remove support for glide yet, and it's still used with go versions 1.7 and 1.8 in travis.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@yogiraj07 yogiraj07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update readme to install dependencies using each package management with respective Go version? Currently it says just Glide.

@chrisradek
Copy link
Contributor Author

Good call-out, I'll update the readme.

@luluzhao luluzhao merged commit 9bde012 into aws:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants