Remove dep pkg manager and excess CI steps #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
remove-dep-tool
branch
from
69ae355 to
547ac21
Compare
NathanielRN
commented
Jan 18, 2022
.github/workflows/test.yml
Outdated
| go version | ||
| echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV | ||
| echo "${{ github.workspace }}/bin" >> $GITHUB_PATH | ||
|
|
There was a problem hiding this comment.
I left this space because my VSCode IDE only does correct syntax highlighting for the comment if I have this space here... let me know if this is undesirable!
anuraaga
reviewed
Jan 19, 2022
NathanielRN
force-pushed
the
remove-dep-tool
branch
from
547ac21 to
63d0aae
Compare
NathanielRN
changed the title
anuraaga
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks for bringing this issue up @anuraaga ! I looked through old PRs like #90 and read your description to come up with this PR to remove
dep.One concern I have was that you said we could> for example #265 becomes trivial to solve by compressing our build down to a single command.so I looked at how we ended up fixing #265 in #267 and noticed these lines:I'm not too familiar withgo, but does removingdepmean we don't need these lines anymore?Actually I just tested this on my own branch on my fork and it works fine so I will remove these lines. Please let me know if I'm wrong!Also when you sayDid I do that correctly in this PR because we only havego help downloadnow?If it would be more convenient to link me todepdocumentation where I can verify this is not needed please feel free to do that!Did a final test with all your comments and the test still passes on my fork. This change should drop the size of the CI a lot!
Fixes #266
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.