Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate plugins directory and sql.go file #215

Merged
merged 17 commits into from
Apr 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ Note that the `xray.Config{}` fields `LogLevel` and `LogFormat` are deprecated s

***Plugins***

The plugins under "github.com/aws/aws-xray-sdk-go/plugins/" are activated at package load time. This can be convenient in some cases, but often you want to load them conditionally at runtime (e.g. don't load in tests). For this purpose, there is a new set of plugins under "github.com/aws/aws-xray-sdk-go/awsplugins/" that have an explicit `Init()` function you must call to load the plugin:
Plugins can be loaded conditionally at runtime. For this purpose, plugins under "github.com/aws/aws-xray-sdk-go/awsplugins/" have an explicit `Init()` function. Customer must call this method to load the plugin:

```go
import (
Expand Down Expand Up @@ -226,9 +226,6 @@ func main() {
row, err := db.QueryRowContext(ctx, "SELECT 1") // Use as normal
}
```

Note that the `xray.SQL` are deprecated and will be remove when the SDK becomes GA.

**Lambda**

```
Expand Down
18 changes: 0 additions & 18 deletions plugins/beanstalk/beanstalk.go

This file was deleted.

18 changes: 0 additions & 18 deletions plugins/ec2/ec2.go

This file was deleted.

18 changes: 0 additions & 18 deletions plugins/ecs/ecs.go

This file was deleted.

136 changes: 0 additions & 136 deletions xray/sql.go

This file was deleted.