Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate plugins directory and sql.go file #215

Merged
merged 17 commits into from
Apr 1, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added reviewdog suggestions
  • Loading branch information
bhautikpip committed Feb 28, 2020
commit 6b620c65f695476a1ae59b77529eb5e78905f52a
8 changes: 4 additions & 4 deletions xray/segment.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,9 @@ func BeginSegmentWithSampling(ctx context.Context, name string, r *http.Request,

if seg.Sampled {
return context.WithValue(ctx, ContextKey, seg), seg
} else {
return BeginDummySegment(ctx, "Dummy Seg")
}

return BeginDummySegment(ctx, "Dummy Seg")
}

func basicSegment(name string, h *header.Header) *Segment {
Expand Down Expand Up @@ -294,9 +294,9 @@ func BeginSubsegment(ctx context.Context, name string) (context.Context, *Segmen

if seg.ParentSegment.Sampled {
return context.WithValue(ctx, ContextKey, seg), seg
} else {
return BeginDummySegment(ctx, "Dummy SubSeg")
}

return BeginDummySegment(ctx, "Dummy SubSeg")
}

// NewSegmentFromHeader creates a segment for downstream call and add information to the segment that gets from HTTP header.
Expand Down