Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove abstract yard tag #2452

Merged
merged 3 commits into from
Dec 21, 2018
Merged

Remove abstract yard tag #2452

merged 3 commits into from
Dec 21, 2018

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Dec 21, 2018

  • npm run test passes
  • changelog is added, npm run add-change
  • run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed

AllanZhengYP
AllanZhengYP approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you for the work!

@codecov-io
Copy link

codecov-io commented Dec 21, 2018 •
edited
Loading

Codecov Report

Merging #2452 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2452   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files         278      278           
  Lines        8465     8465           
  Branches     1608     1608           
=======================================
  Hits         8197     8197           
  Misses        268      268
Impacted Files Coverage Δ
lib/service.js 98.05% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a872ad...5e09d40. Read the comment docs.

@srchase srchase mentioned this pull request Dec 21, 2018
Closed
@AllanZhengYP
Copy link
Contributor

Approval still stands!

@srchase srchase merged commit 3699772 into aws:master Dec 21, 2018
@srchase srchase deleted the remove-abstract-yard-tag branch December 21, 2018 21:18
@srchase
Copy link
Contributor Author

srchase commented Dec 21, 2018

fix for #2450

@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srchase @codecov-io @AllanZhengYP