Skip to content

Commit

Permalink
Merge pull request #2452 from srchase/remove-abstract-yard-tag
Browse files Browse the repository at this point in the history
Remove abstract yard tag
  • Loading branch information
srchase authored Dec 21, 2018
2 parents 2a872ad + 5e09d40 commit 3699772
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changes/next-release/bugfix-documentation-0a81a38c.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "bugfix",
"category": "documentation",
"description": "swap abstract Yard tag for custom tags to support compatibility with google-closure-compiler"
}
2 changes: 2 additions & 0 deletions .yardopts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
--define-class-expr (AWS\.util\.)?inherit
--update-class-expr (AWS\.util\.)?update
--mixin-module-expr (AWS\.util\.)?mixin
--tag class_abstract:"Abstract Class"
--tag method_abstract:"Abstract Method"
lib/core.js
lib/**/*.js
-
Expand Down
4 changes: 2 additions & 2 deletions lib/service.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ var clientCount = 0;
/**
* The service class representing an AWS service.
*
* @abstract
* @class_abstract This class is an abstract class.
*
* @!attribute apiVersions
* @return [Array<String>] the list of API versions supported by this service.
Expand Down Expand Up @@ -428,7 +428,7 @@ AWS.Service = inherit({
* Override this method to setup any custom request listeners for each
* new request to the service.
*
* @abstract
* @method_abstract This is an abstract method.
*/
setupRequestListeners: function setupRequestListeners(request) {
},
Expand Down

0 comments on commit 3699772

Please sign in to comment.