feat: Add support for the aws.query protocol #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the `aws.query` protocol, building on top of the `HttpRpcProtocolGenerator` and `Xml[Member|Shape]DeserVisitor` for document serde. Implementations of the `Document[Member|Shape]SerVisitor` have been created that handle form-urlencoded bodies, respecting Smithy's `@xmlName` trait. Assorted minor updates for abstraction and in coordination with updates to the base class have also been made.
kstich
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #741 +/- ##
===============================================
Coverage 92.58% 92.58%
===============================================
Files 138 138
Lines 2684 2684
Branches 463 463
===============================================
Hits 2485 2485
Misses 199 199Continue to review full report at Codecov.
|
JordonPhillips
suggested changes
Jan 16, 2020
...odegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/QueryShapeSerVisitor.java
Show resolved
Hide resolved
JordonPhillips
approved these changes
Jan 16, 2020
trivikr
approved these changes
Jan 16, 2020
Merged
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the
aws.queryprotocol, buildingon top of the
HttpRpcProtocolGeneratorandXml[Member|Shape]DeserVisitorfor document serde.
Implementations of the
Document[Member|Shape]SerVisitorhave beencreated that handle form-urlencoded bodies, respecting Smithy's
@xmlNametrait.
Assorted minor updates for abstraction and in coordination with updates
to the base class have also been made.
Depends on smithy-lang/smithy-typescript#102
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.