Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use optional chaining #1021

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 20, 2020

Issue #, if available:
Refs: #1015

Description of changes:
Support for Optional Chaining was added in TS 3.7
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#optional-chaining

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@trivikr trivikr force-pushed the optional-chaining branch from ddab677 to 44dd615 Compare March 20, 2020 02:38
@aws-sdk-js-automation

This comment has been minimized.

@codecov-io
Copy link

codecov-io commented Mar 20, 2020

Codecov Report

Merging #1021 into smithy-codegen will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen    #1021   +/-   ##
===============================================
  Coverage           91.36%   91.36%           
===============================================
  Files                 144      144           
  Lines                2837     2837           
  Branches              502      504    +2     
===============================================
  Hits                 2592     2592           
  Misses                245      245
Impacted Files Coverage Δ
packages/body-checksum-node/src/index.ts 100% <100%> (ø) ⬆️
...kages/fetch-http-handler/src/fetch-http-handler.ts 95.45% <100%> (ø) ⬆️
packages/property-provider/src/chain.ts 100% <100%> (ø) ⬆️
packages/middleware-stack/src/MiddlewareStack.ts 88.61% <100%> (ø) ⬆️
...ackages/node-http-handler/src/node-http-handler.ts 100% <100%> (ø) ⬆️
packages/middleware-retry/src/retryDecider.ts 100% <100%> (ø) ⬆️
packages/chunked-stream-reader-node/src/index.ts 100% <100%> (ø) ⬆️
packages/body-checksum-browser/src/index.ts 100% <100%> (ø) ⬆️
packages/signature-v4/src/getCanonicalHeaders.ts 100% <100%> (ø) ⬆️
...ckages/node-http-handler/src/node-http2-handler.ts 81.35% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a447740...e5ea4a5. Read the comment docs.

@trivikr trivikr force-pushed the optional-chaining branch from 5b83b31 to e5ea4a5 Compare March 20, 2020 05:07
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: e5ea4a5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit eea9652 into aws:smithy-codegen Mar 20, 2020
@trivikr trivikr deleted the optional-chaining branch March 20, 2020 17:25
AllanZhengYP pushed a commit to AllanZhengYP/aws-sdk-js-v3 that referenced this pull request Mar 20, 2020
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request Mar 20, 2020
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request Mar 24, 2020
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request Mar 24, 2020
@lock
Copy link

lock bot commented Mar 27, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants