chore: use optional chaining

aws · Mar 20, 2020 · 44dd615 · 44dd615
1 parent a447740
commit 44dd615
Show file tree

Hide file tree

Showing 12 changed files with 20 additions and 24 deletions.
diff --git a/packages/body-checksum-browser/src/index.ts b/packages/body-checksum-browser/src/index.ts
@@ -26,8 +26,8 @@ export async function bodyChecksumGenerator(
       await blobReader(
         body,
         (chunk: any) => {
-          treeHash && treeHash.update(chunk);
-          contentHash && contentHash.update(chunk);
+          treeHash?.update(chunk);
+          contentHash?.update(chunk);
         },
         MiB
       );

diff --git a/packages/body-checksum-node/src/index.ts b/packages/body-checksum-node/src/index.ts
@@ -20,8 +20,8 @@ export async function bodyChecksumGenerator(
     ArrayBuffer.isView(body) ||
     isArrayBuffer(body)
   ) {
-    contentHash && contentHash.update(body);
-    treeHash && treeHash.update(body);
+    contentHash?.update(body);
+    treeHash?.update(body);
   } else {
     if (typeof body.path !== "string") {
       throw new Error("Unable to calculate checksums for non-file streams.");
@@ -32,8 +32,8 @@ export async function bodyChecksumGenerator(
     });
 
     await streamReader(bodyTee, (chunk: any) => {
-      contentHash && contentHash.update(chunk);
-      treeHash && treeHash.update(chunk);
+      contentHash?.update(chunk);
+      treeHash?.update(chunk);
     });
   }
 

diff --git a/packages/chunked-stream-reader-node/src/index.ts b/packages/chunked-stream-reader-node/src/index.ts
@@ -9,7 +9,7 @@ export function streamReader(
 
     stream.on("error", reject);
     stream.on("end", () => {
-      if (temporaryBuffer && temporaryBuffer.byteLength) {
+      if (temporaryBuffer?.byteLength) {
         for (let i = 0; i < temporaryBuffer.byteLength; i += chunkSize) {
           onChunk(
             temporaryBuffer.subarray(

diff --git a/packages/client-documentation-generator/src/sdk-client-toc-plugin.ts b/packages/client-documentation-generator/src/sdk-client-toc-plugin.ts
@@ -85,7 +85,7 @@ export class SdkClientTocPlugin extends RendererComponent {
   }
 
   private isUnion(model: DeclarationReflection): boolean {
-    return model.type && model.type.type === "union";
+    return model.type?.type === "union";
   }
 
   private isInputOrOutput(model: DeclarationReflection): boolean {

diff --git a/packages/credential-provider-cognito-identity/src/localStorage.spec.ts b/packages/credential-provider-cognito-identity/src/localStorage.spec.ts
@@ -2,8 +2,8 @@ import { localStorage } from "./localStorage";
 import { IndexedDbStorage } from "./IndexedDbStorage";
 
 describe("localStorage", () => {
-  const storageAtInit: Storage | undefined = window && window.localStorage;
-  const idbAtInit: IDBFactory | undefined = self && self.indexedDB;
+  const storageAtInit: Storage | undefined = window?.localStorage;
+  const idbAtInit: IDBFactory | undefined = self?.indexedDB;
 
   beforeEach(() => {
     if (window) {

diff --git a/packages/fetch-http-handler/src/fetch-http-handler.ts b/packages/fetch-http-handler/src/fetch-http-handler.ts
@@ -36,11 +36,11 @@ export class FetchHttpHandler implements HttpHandler {
     request: HttpRequest,
     options: HttpHandlerOptions
   ): Promise<{ response: HttpResponse }> {
-    const abortSignal = options && options.abortSignal;
+    const abortSignal = options?.abortSignal;
     const requestTimeoutInMs = this.httpOptions.requestTimeout;
 
     // if the request was already aborted, prevent doing extra work
-    if (abortSignal && abortSignal.aborted) {
+    if (abortSignal?.aborted) {
       const abortError = new Error("Request aborted");
       abortError.name = "AbortError";
       return Promise.reject(abortError);

diff --git a/packages/middleware-retry/src/retryDecider.ts b/packages/middleware-retry/src/retryDecider.ts
@@ -31,5 +31,5 @@ export const defaultRetryDecider = (error: SdkError) => {
 };
 
 function hasMetadata(error: any): error is MetadataBearer {
-  return error && error.$metadata;
+  return error?.$metadata;
 }
diff --git a/packages/middleware-stack/src/MiddlewareStack.ts b/packages/middleware-stack/src/MiddlewareStack.ts
@@ -401,7 +401,7 @@ export class MiddlewareStack<Input extends object, Output extends object> {
         : defaultAnchorValue;
       let relativeEntry = prev;
       //reverse relative entry linked list and add to ordered handler list
-      while (relativeEntry && relativeEntry.prev) {
+      while (relativeEntry?.prev) {
         relativeEntry = relativeEntry.prev;
       }
       while (relativeEntry) {

diff --git a/packages/node-http-handler/src/node-http-handler.ts b/packages/node-http-handler/src/node-http-handler.ts
@@ -60,7 +60,7 @@ export class NodeHttpHandler implements HttpHandler {
   ): Promise<{ response: HttpResponse }> {
     return new Promise((resolve, reject) => {
       // if the request was already aborted, prevent doing extra work
-      if (abortSignal && abortSignal.aborted) {
+      if (abortSignal?.aborted) {
         const abortError = new Error("Request aborted");
         abortError.name = "AbortError";
         reject(abortError);

diff --git a/packages/node-http-handler/src/node-http2-handler.ts b/packages/node-http-handler/src/node-http2-handler.ts
@@ -46,7 +46,7 @@ export class NodeHttp2Handler implements HttpHandler {
   ): Promise<{ response: HttpResponse }> {
     return new Promise((resolve, reject) => {
       // if the request was already aborted, prevent doing extra work
-      if (abortSignal && abortSignal.aborted) {
+      if (abortSignal?.aborted) {
         const abortError = new Error("Request aborted");
         abortError.name = "AbortError";
         reject(abortError);

diff --git a/packages/property-provider/src/chain.ts b/packages/property-provider/src/chain.ts
@@ -17,7 +17,7 @@ export function chain<T>(...providers: Array<Provider<T>>): Provider<T> {
     );
     for (const provider of providers) {
       promise = promise.catch((err: any) => {
-        if (err && err.tryNextLink) {
+        if (err?.tryNextLink) {
           return provider();
         }
 

diff --git a/packages/signature-v4/src/getCanonicalHeaders.ts b/packages/signature-v4/src/getCanonicalHeaders.ts
@@ -18,16 +18,12 @@ export function getCanonicalHeaders(
     const canonicalHeaderName = headerName.toLowerCase();
     if (
       canonicalHeaderName in ALWAYS_UNSIGNABLE_HEADERS ||
-      (unsignableHeaders && unsignableHeaders.has(canonicalHeaderName)) ||
+      unsignableHeaders?.has(canonicalHeaderName) ||
+      !signableHeaders?.has(canonicalHeaderName) ||
       PROXY_HEADER_PATTERN.test(canonicalHeaderName) ||
       SEC_HEADER_PATTERN.test(canonicalHeaderName)
     ) {
-      if (
-        !signableHeaders ||
-        (signableHeaders && !signableHeaders.has(canonicalHeaderName))
-      ) {
-        continue;
-      }
+      continue;
     }
 
     canonical[canonicalHeaderName] = headers[headerName]