Fix Erroneous "No BuildArchitecture specified in Layer" Warning #6508
Conversation
bentvelj
force-pushed
the
bentvels-fix-6444
branch
from
51fea81 to
e302c4f
Compare
samcli/lib/build/app_builder.py
Outdated
| LOG.warning( | ||
| "WARNING: No BuildArchitecture specified in Layer `%s`" + " Metadata. Defaulting to x86_64.", | ||
| layer_name, | ||
| ) |
There was a problem hiding this comment.
I think we want to print this warning message if layer has arm64 architecture as CompatibleArchitectures but it doesn't have BuildArchitecture property
There was a problem hiding this comment.
There is another warning in the LayerVersion constructor that should take care of this.
It would output
WARNING: Layer `Layer` has BuildArchitecture `x86_64`, which is not listed in CompatibleArchitectures.
There was a problem hiding this comment.
This may be slightly confusing if the customer doesn't know that x86 is the default? Maybe we can adjust the messaging here
There was a problem hiding this comment.
My concern with this one is; if I have a layer which is supposed to be built with x86 I will keep getting these warning messages all the time, which can be annoying.
There was a problem hiding this comment.
Right. As discussed, going to restructure according to these rules:
There are two cases where we'd like to warn the customer
- Compatible Architectures is only x86 (or not present) but Build Architecture is arm64
- Build Architecture is x86 (or not present) but Compatible Architectures is only arm64
Which issue(s) does this change fix?
#6444
Why is this change necessary?
Customers were reporting the warning of
No BuildArchitecture specified in Layerwhen building Lambda Functions which referenced existing Lambda Layers. The error message also incorrectly appears while building Lambda Layers without a BuildMethod at all.How does it address the issue?
Moved the logic which checks for missing BuildArchitecture from the LayerVersion constructor to the app builder
build_layerfunction, so that warnings are not printed for layers that are not built.What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.