Code

Auto ECR Companion Stack Deletion#3080

Code

Merged

hawflau merged 128 commits intoaws:feat/sam_deleteaws/aws-sam-cli:feat/sam_deletefrom hnnasit:revert-wiltons-codehnnasit/aws-sam-cli:revert-wiltons-codeCopy head branch name to clipboardJul 21, 2021

+604-101

Commits

Commits on Mar 1, 2021

• Added ecr_bootstrap

  CoshUS

  committed
  f12e425

  Copy full SHA for f12e425

• Added companion_stack_manager

  CoshUS

  committed
  650fe2c

  Copy full SHA for 650fe2c

• Added Companion Stack Manager

  CoshUS

  committed
  5397803

  Copy full SHA for 5397803

• Added update_companion_stack

  CoshUS

  committed
  6751928

  Copy full SHA for 6751928

• Updated companion_stack_builder File Name

  CoshUS

  committed
  6c034ec

  Copy full SHA for 6c034ec

• Formatted with Black

  CoshUS

  committed
  f6204af

  Copy full SHA for f6204af

• Updated get_unreferenced_repos

  CoshUS

  committed
  13b425f

  Copy full SHA for 13b425f

• Updated guided_context to Use Companion Stack

  CoshUS

  committed
  25d2dad

  Copy full SHA for 25d2dad

• Added Delete Auto Create ECR Repo Prompt

  CoshUS

  committed
  fbe5a66

  Copy full SHA for fbe5a66

• Updated prompt_image_repository Flow

  CoshUS

  committed
  0b9a881

  Copy full SHA for 0b9a881

Commits on Mar 4, 2021

• Added --resolve-image-repos

  CoshUS

  committed
  676fa01

  Copy full SHA for 676fa01

• Addressed Some of Pylint Issues

  CoshUS

  committed
  2e16290

  Copy full SHA for 2e16290

Commits on Apr 14, 2021

• Updated Helper Text

  CoshUS

  committed
  739b550

  Copy full SHA for 739b550

• Merge branch 'develop' into feat/auto-ecr

  CoshUS

  committed
  c48e07d

  Copy full SHA for c48e07d

• Updated Comments

  CoshUS

  committed
  701932c

  Copy full SHA for 701932c

• Fixed Typing

  CoshUS

  committed
  f1f9f45

  Copy full SHA for f1f9f45

• Removed Unused Imports

  CoshUS

  committed
  b82d544

  Copy full SHA for b82d544

Commits on Apr 15, 2021

• Updated Unit Tests

  CoshUS

  committed
  2d2cf5b

  Copy full SHA for 2d2cf5b

• Updated UX and Fixed Windows ANSI

  CoshUS

  committed
  9fb143e

  Copy full SHA for 9fb143e

Commits on Apr 16, 2021

• Updated Unit Tests

  CoshUS

  committed
  f015829

  Copy full SHA for f015829

• Fixed Import Order

  CoshUS

  committed
  cdef3a6

  Copy full SHA for cdef3a6

• Merge branch 'develop' into feat/auto-ecr

  CoshUS

  authored
  23576c3

  Copy full SHA for 23576c3

• Added Ignore Import Check

  CoshUS

  committed
  6dd8c67

  Copy full SHA for 6dd8c67

• Added Integration Tests

  CoshUS

  committed
  addd5a1

  Copy full SHA for addd5a1

• Merge branch 'develop' into feat/auto-ecr

  CoshUS

  authored
  92002d4

  Copy full SHA for 92002d4

• Updated help text.

  Show description for edf778d
  

  CoshUS

  and

  Chris Rehn

  authored
  edf778d

  Copy full SHA for edf778d

• Added Comments for Name Generation

  CoshUS

  committed
  f8244a4

  Copy full SHA for f8244a4

Commits on Apr 19, 2021

• Updated Image Option Validator

  CoshUS

  committed
  0214950

  Copy full SHA for 0214950

• Updated CompanionStackBuilder to Use Dict instead of String

  CoshUS

  committed
  7b5a46c

  Copy full SHA for 7b5a46c

• Merge branch 'develop' into feat/auto-ecr

  CoshUS

  authored
  c6f2698

  Copy full SHA for c6f2698

Commits on Apr 23, 2021

• Fixed Argument Ordering

  CoshUS

  committed
  5edd495

  Copy full SHA for 5edd495

• Merge branch 'develop' into feat/auto-ecr

  CoshUS

  authored
  7b3572e

  Copy full SHA for 7b3572e

Commits on Apr 26, 2021

• Added Mapping Information to Help Text

  CoshUS

  committed
  9ffd4bd

  Copy full SHA for 9ffd4bd

• Merge branch 'feat/auto-ecr' of https://github.com/CoshUS/aws-sam-cli into feat/auto-ecr

  CoshUS

  committed
  a83f7fc

  Copy full SHA for a83f7fc

• Updated delete_unreferenced_repos Doc String

  CoshUS

  committed
  79ef739

  Copy full SHA for 79ef739

• Updated sync_repos Doc String

  CoshUS

  committed
  90b5b4c

  Copy full SHA for 90b5b4c

• Added Justification for ECR Repo Physical ID

  CoshUS

  committed
  4157cb9

  Copy full SHA for 4157cb9

• Refactored to be Less Coupled

  CoshUS

  committed
  5d84813

  Copy full SHA for 5d84813

• Refactored for prompt_specify_repos

  CoshUS

  committed
  ce355cf

  Copy full SHA for ce355cf

• Fixed Unit Test

  CoshUS

  committed
  366b7f7

  Copy full SHA for 366b7f7

• Moved WaiterConfig Out of Methods

  CoshUS

  committed
  c653dff

  Copy full SHA for c653dff

• Updated Typing

  CoshUS

  committed
  4be0e11

  Copy full SHA for 4be0e11

• Updated Managed S3 Template to be Dict

  CoshUS

  committed
  c18ad41

  Copy full SHA for c18ad41

• Fixed Typo

  CoshUS

  committed
  191309a

  Copy full SHA for 191309a

• Added Comments for _save_image_repositories

  CoshUS

  committed
  bfdf4a7

  Copy full SHA for bfdf4a7

• Fixed Pylint Issue

  CoshUS

  committed
  e03c48a

  Copy full SHA for e03c48a

• Merge branch 'develop' into feat/auto-ecr

  CoshUS

  authored
  b016b14

  Copy full SHA for b016b14

Commits on Apr 27, 2021

• Added Missing Check for unreferenced_repo_uris

  CoshUS

  committed
  85ced27

  Copy full SHA for 85ced27

• Merge branch 'feat/auto-ecr' of https://github.com/CoshUS/aws-sam-cli into feat/auto-ecr

  CoshUS

  committed
  6c3f54a

  Copy full SHA for 6c3f54a

Commits on May 3, 2021

• Merge branch 'develop' into feat/auto-ecr

  mgrandis

  authored
  1946945

  Copy full SHA for 1946945

Commits on May 4, 2021

• Updated Variable Name

  CoshUS

  committed
  7693d9a

  Copy full SHA for 7693d9a

• Fixed Typo

  CoshUS

  committed
  6393418

  Copy full SHA for 6393418

• Updated Windows Check to Use platform.system()

  CoshUS

  committed
  7411f9f

  Copy full SHA for 7411f9f

• Updated update_companion_stack Logic

  CoshUS

  committed
  f3b5bcb

  Copy full SHA for f3b5bcb

• Merge branch 'feat/auto-ecr' of https://github.com/CoshUS/aws-sam-cli into feat/auto-ecr

  CoshUS

  committed
  3039f18

  Copy full SHA for 3039f18

• Fixed Comment Typo

  CoshUS

  committed
  3575581

  Copy full SHA for 3575581

• Fixed Typos

  CoshUS

  committed
  17a7a41

  Copy full SHA for 17a7a41

• Fixed Test Name

  CoshUS

  committed
  8a1c458

  Copy full SHA for 8a1c458

Commits on Jun 21, 2021

• Added methods for cf and s3 files and init UI

  hnnasit

  committed
  1263735

  Copy full SHA for 1263735

Commits on Jun 23, 2021

• Added unit tests for utils methods and s3_uploader

  hnnasit

  committed
  ba47369

  Copy full SHA for ba47369

Commits on Jun 24, 2021

• Removed s3_bucket and s3_prefix click options

  hnnasit

  committed
  d77f7c4

  Copy full SHA for d77f7c4

• chore: Increase awareness of same file warning during package (aws#2946)

  Show description for d506648
  

  mndeveci

  and

  mgrandis

  authored
  d506648

  Copy full SHA for d506648

• fix: Allow the base64Encoded field in REST Api, skip validation of unknown fields and validate missing statusCode for Http Api (aws#2941)

  Show description for 698de67
  moelasmar

  authored
  698de67

  Copy full SHA for 698de67

Commits on Jun 25, 2021

• Fixed lint errors and added few unit tests

  hnnasit

  committed
  3f6f070

  Copy full SHA for 3f6f070

• Make black happy

  hnnasit

  committed
  af2f929

  Copy full SHA for af2f929

Commits on Jun 28, 2021

• Merge pull request #1 from hnnasit/delete-cf-s3-methods

  Show description for 481ef8a
  hnnasit

  authored
  481ef8a

  Copy full SHA for 481ef8a

• Added methods for deleting template artifacts

  hnnasit

  committed
  1d70155

  Copy full SHA for 1d70155

• Wait method added for delete cf api

  hnnasit

  committed
  e3f7872

  Copy full SHA for e3f7872

Commits on Jun 29, 2021

• fix: pass copy of environment variables for keeping cache valid (aws#2943)

  Show description for 3b2cdf1
  

  mndeveci

  and

  qingchm

  authored
  3b2cdf1

  Copy full SHA for 3b2cdf1

• Added LOG statements

  hnnasit

  committed
  99f7db4

  Copy full SHA for 99f7db4

• Added and updated changes based on CR

  hnnasit

  committed
  e7304ec

  Copy full SHA for e7304ec

• Fixed the unit tests in artifact_exporter.py

  hnnasit

  committed
  c2e43db

  Copy full SHA for c2e43db

• Update HELP_TEXT in delete/command.py

  Show description for dd35d53
  

  hnnasit

  and

  Chris Rehn

  authored
  dd35d53

  Copy full SHA for dd35d53

• fix: Skip build of Docker image if ImageUri is a valid ECR URL (aws#2934) (aws#2935)

  alexisfacques

  authored
  6fc1b99

  Copy full SHA for 6fc1b99

Commits on Jun 30, 2021

• Updated code based on Chris' comments

  hnnasit

  committed
  f43e763

  Copy full SHA for f43e763

• Added condition for resources that have deletionpolicy specified

  hnnasit

  committed
  5779cd3

  Copy full SHA for 5779cd3

• Small changes and fixes based on the comments

  hnnasit

  committed
  bc9db14

  Copy full SHA for bc9db14

• Add condition to managed bucket policy (aws#2999)

  qingchm

  authored
  0d58f89

  Copy full SHA for 0d58f89

• Removed region prompt

  hnnasit

  committed
  401a950

  Copy full SHA for 401a950

Commits on Jul 1, 2021

• Update appveyor.yml to do docker login on both dockerhub and Public ECR (aws#3005) (aws#3006)

  Show description for 50ac3cb
  

  qingchm

  and

  hawflau

  authored
  50ac3cb

  Copy full SHA for 50ac3cb

• chore: bump version to 1.25.0 (aws#3007)

  Show description for f1e0569
  

  qingchm

  and

  sriram-mv

  authored
  f1e0569

  Copy full SHA for f1e0569

• temp: reduce python testing matrix (aws#3008)

  sriram-mv

  authored
  2241563

  Copy full SHA for 2241563

• temp: disable testing against python 3.8, and enabled 3.7 (aws#3009)

  Show description for fe83218
  moelasmar

  authored
  fe83218

  Copy full SHA for fe83218

• fix: enable all runtimes in python testing matrix (aws#3011)

  Show description for cc806a2
  qingchm

  authored
  cc806a2

  Copy full SHA for cc806a2

Commits on Jul 3, 2021

• Added unit tests for ecr delete method and typing for methods

  hnnasit

  committed
  0a38340

  Copy full SHA for 0a38340

• Merge branch 'delete-template-artifacts' into delete-cf-s3-methods

  hnnasit

  authored
  8977c6a

  Copy full SHA for 8977c6a

• Merge pull request #2 from hnnasit/delete-cf-s3-methods

  Show description for 99c80e1
  hnnasit

  authored
  99c80e1

  Copy full SHA for 99c80e1

Commits on Jul 5, 2021

• Reformatted delete_context and added option to skip user prompts

  hnnasit

  committed
  aaa1b05

  Copy full SHA for aaa1b05

• Removed return type from artifact_exporter for delete method

  hnnasit

  committed
  e2e85a9

  Copy full SHA for e2e85a9

• Added unit tests for artifact_exporter and delete_context

  hnnasit

  committed
  c98e6ee

  Copy full SHA for c98e6ee

• Added more unit tests for delete_context and artifact_exporter

  hnnasit

  committed
  17a427a

  Copy full SHA for 17a427a

Commits on Jul 6, 2021

• chore: update to aws-sam-translator 1.37.0 (aws#3019)

  mgrandis

  authored
  ac4e485

  Copy full SHA for ac4e485

• chore: bump version to 1.26.0 (aws#3020)

  mgrandis

  authored
  a1e5c92

  Copy full SHA for a1e5c92

• Added more unit tests for delete_context and artifact_exporter

  hnnasit

  committed
  e577d7f

  Copy full SHA for e577d7f

• Merged feat/sam_delete changes into delete_template_artifacts repo

  hnnasit

  committed
  70eac98

  Copy full SHA for 70eac98

• Added docs and comments for artifact_exporter and ecr_uploader

  hnnasit

  committed
  58ead71

  Copy full SHA for 58ead71

Commits on Jul 7, 2021

• Added log statements in delete_context and some updates in unit tests

  hnnasit

  committed
  45ee66f

  Copy full SHA for 45ee66f

Commits on Jul 8, 2021

• Changed force to no-prompts and updated ecr delete method error handling

  hnnasit

  committed
  d151b01

  Copy full SHA for d151b01

• chore: Improved --resolve-s3 option documentation and deployment without s3 error messages (aws#2983)

  Show description for 59c8576
  qingchm

  authored
  59c8576

  Copy full SHA for 59c8576

Commits on Jul 9, 2021

• Created a separate function for parsing ecr url in ecr_uploader

  hnnasit

  committed
  6f54240

  Copy full SHA for 6f54240

• Reformatted Template class init to pass template_str and init template_dict

  hnnasit

  committed
  30e3c02

  Copy full SHA for 30e3c02

• Changed how s3 url is obtained for resource_zip edge-case: aws:glue:job

  hnnasit

  committed
  b8a2591

  Copy full SHA for b8a2591

• Fixed edge case where resource artifact points to a path style url

  hnnasit

  committed
  7292353

  Copy full SHA for 7292353

• run Make black

  hnnasit

  committed
  6ff2e22

  Copy full SHA for 6ff2e22

Commits on Jul 10, 2021

• Made the parse s3 url funcs protected and defined a parent method and modified delete method for ResourceImageDict

  hnnasit

  committed
  6c9a060

  Copy full SHA for 6c9a060

Commits on Jul 12, 2021

• Changed parse_ecr_url function name to parse_image_url

  hnnasit

  committed
  1675b7e

  Copy full SHA for 1675b7e

• Merge branch 'develop' into feat/auto-ecr

  CoshUS

  committed
  c4e9632

  Copy full SHA for c4e9632

Commits on Jul 13, 2021

• Merge remote-tracking branch 'wiltons-repo/feat/auto-ecr' into auto-ecr-delete

  hnnasit

  committed
  0e159c2

  Copy full SHA for 0e159c2

• Defined UI for auto ecr deleton and method calls from companion_stack_manager

  hnnasit

  committed
  5355028

  Copy full SHA for 5355028

• Added code for deleting repos from companion stack

  hnnasit

  committed
  b160efc

  Copy full SHA for b160efc

Commits on Jul 14, 2021

• Handle json templates deployed to cf

  hnnasit

  committed
  4267e82

  Copy full SHA for 4267e82

• Changed the order of companion stack and ecr repos deletion

  hnnasit

  committed
  b172255

  Copy full SHA for b172255

Commits on Jul 15, 2021

• Handle delete_failed status for ecr companion stack and changed delete_stack to include retain_resources

  hnnasit

  committed
  7b5732d

  Copy full SHA for 7b5732d

• Reformatted auto ecr deletion to handle deleting companion stack as input stack name

  hnnasit

  committed
  bbe7cec

  Copy full SHA for bbe7cec

• Fixed and added more unit tests for delete_context

  hnnasit

  committed
  8b0d979

  Copy full SHA for 8b0d979

Commits on Jul 16, 2021

• When region is not provided, prompt user to enter profile and region

  hnnasit

  committed
  189e383

  Copy full SHA for 189e383

Commits on Jul 18, 2021

• Removed region prompt and reading it from current session or assign a default instead

  hnnasit

  committed
  a933202

  Copy full SHA for a933202

Commits on Jul 19, 2021

• Added ECR resource in packageable_resources and refactored ecr companion stack deletion

  hnnasit

  committed
  80f6561

  Copy full SHA for 80f6561

• Added log statements and unit tests for ECRResource

  hnnasit

  committed
  8d19497

  Copy full SHA for 8d19497

• Merged feat/sam_delete changes into auto-ecr-delete

  hnnasit

  committed
  b7ffe45

  Copy full SHA for b7ffe45

• Better error handling for ecr delete_artifact

  hnnasit

  committed
  7bcd636

  Copy full SHA for 7bcd636

Commits on Jul 20, 2021

• Revert "Merge remote-tracking branch 'wiltons-repo/feat/auto-ecr' into auto-ecr-delete"

  Show description for 9363b93
  hnnasit

  committed
  9363b93

  Copy full SHA for 9363b93

• Added unit test for delete ecr repository

  hnnasit

  committed
  203ea3a

  Copy full SHA for 203ea3a

• Fixed small string nits and added docstring for ECRResource

  hnnasit

  committed
  0b25fbb

  Copy full SHA for 0b25fbb

• Added some unit tests for s3_uploader, ecr_uploader and delete_context

  hnnasit

  committed
  37a6510

  Copy full SHA for 37a6510

• Updated to context refresh only when region and profile have non None values and removed unused class variable in delete_context

  hnnasit

  committed
  d3e0782

  Copy full SHA for d3e0782

• Added unit test for ResourceImageDict class methods

  hnnasit

  committed
  80d5428

  Copy full SHA for 80d5428

Commits on Jul 21, 2021

• Merge remote-tracking branch 'upstream/feat/sam_delete' into revert-wiltons-code

  hnnasit

  committed
  ec467db

  Copy full SHA for ec467db