Sync delete-template-artifacts branch with delete-cf-s3-methods #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chris Rehn <[email protected]>
hnnasit
pushed a commit
that referenced
this pull request
Nov 16, 2022
* feat: add dotnet7 build method (aws#428) * # This is a combination of 2 commits. # This is the 1st commit message: Add dotnet7 build method for provided * Added 'BuildMethod: dotnet7' using 'Runtime:provided' * 'Runtime:provided' is only for the provided runtime and not the dotnet runtime Testing with sample SAM template: ( See BuildMethod and Runtime below ) ... HelloWorldFunction: Type: AWS::Serverless::Function Metadata: BuildMethod: dotnet7 Properties: CodeUri: ./src/HelloWorld/ Handler: HelloWorld::HelloWorld.Function::FunctionHandler Runtime: provided Architectures: - x86_64 ... # This is the commit message #2: Add dotnet7 build method for provided * Added 'BuildMethod: dotnet7' using 'Runtime:provided' * 'Runtime:provided' is only for the provided runtime and not the dotnet runtime Testing with sample SAM template: ( See BuildMethod and Runtime below ) ... HelloWorldFunction: Type: AWS::Serverless::Function Metadata: BuildMethod: dotnet7 Properties: CodeUri: ./src/HelloWorld/ Handler: HelloWorld::HelloWorld.Function::FunctionHandler Runtime: provided Architectures: - x86_64 ... * run black reformat Co-authored-by: Samiullah Mohammed <[email protected]> Co-authored-by: Wing Fung Lau <[email protected]> Co-authored-by: Mehmet Nuri Deveci <[email protected]> * update provided with provided.al2 * Update test_build_cmd.py * Update test_workflow_config.py * Update aws-lambda-tools-defaults.json Co-authored-by: Beau Gosse <[email protected]> Co-authored-by: Samiullah Mohammed <[email protected]> Co-authored-by: Wing Fung Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.