chore: Enable some pylint rules and add clarity to pylintrc file #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffa
reviewed
Nov 13, 2020
| @@ -24,20 +24,20 @@ class BuildContext: | |||
| _BUILD_DIR_PERMISSIONS = 0o755 | |||
|
|
|||
| def __init__( | |||
| self, | |||
There was a problem hiding this comment.
Why is the formatting different?
There was a problem hiding this comment.
Well as per @aahung
I just ran black on that file, it does not do anything, then I made a small change, it reformatted it
It seems black isn't yet stable. 😩😩😩
Great PR otherwise, approved.
mgrandis
approved these changes
Nov 13, 2020
hoffa
approved these changes
Nov 14, 2020
elbayaaa
reviewed
Nov 14, 2020
| @@ -263,4 +264,4 @@ def decorator_customize_config_env(f): | |||
| return click.option(*config_env_param_decls, **config_env_attrs)(f) | |||
|
|
|||
|
|
|||
| # End section copied from [[click_config_file][https://github.com/phha/click_config_file/blob/master/click_config_file.py] | |||
| # End section copied from [click_config_file][https://github.com/phha/click_config_file/blob/master/click_config_file.py | |||
There was a problem hiding this comment.
[minor] will the hyperlink work with the last close bracket missed?
There was a problem hiding this comment.
it is a python file so hyperlink won't work anyway
There was a problem hiding this comment.
I don't feel the original comment was trying to follow format like markdown 🤔
7 tasks
sriram-mv
pushed a commit
that referenced
this pull request
Nov 23, 2020
* Revert "chore: Enable pylint compare to zero/empty string" This reverts commit 1e3b282. * Revert "chore: Enable pylint Else If Used checker" This reverts commit 5819ded. * Revert "chore: Remove unnecessary pylint disable" This reverts commit d4a5c46. * Revert "chore: Enable pylint line too long" This reverts commit fb54504. * Revert "chore: Enable pylint multi-processes" This reverts commit b02c8d9. * Revert "chore: Enable pylint rule Unused import" This reverts commit a6eda1d. * Revert "chore: Remove pylint rules that do not apply for python 3" This reverts commit 6212005. * Revert "chore: Make pylintrc ignore rule more readable" This reverts commit fe50385.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
Currently there are multiple pylint rules we disable without clarity. It is hard to find which rules are necessarily to disable, and which are not.
How does it address the issue?
This PR exposes the rule name in pylintrc file, and (re)enabled some rules
What side effects does this change have?
absolutely no side effect
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.