Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the SHA extension implementation of SHA-256/512 on x86 #81

Merged
merged 7 commits into from
Jan 8, 2021
Merged

Enable the SHA extension implementation of SHA-256/512 on x86 #81

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c69bda9
Enable the SHA extension implementation of SHA-256/512 on x86
Dec 16, 2020
6f3a076
Merge branch 'main' into enable_shaext_sha256
bryce-shang Dec 22, 2020
1f2eaf8
Fix the duplicate symbol build error when compiling in FIPS mode
Dec 22, 2020
b0bbcbd
Add dispatch test for SHA extension instructions
dkostic Dec 24, 2020
229dcc9
Small readability improvement
dkostic Jan 4, 2021
0a57abb
Run tests with Intel® Software Development Emulator.
bryce-shang Jan 5, 2021
476e8bd
Correct echo message.
bryce-shang Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions crypto/fipsmodule/sha/asm/sha512-x86_64.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,7 @@
# necessary to disable AVX2 code when SHA Extensions code is disabled? Upstream
# did not tie them together until after $shaext was added.
$avx = 1;

# TODO(davidben): Consider enabling the Intel SHA Extensions code once it's
# been tested.
$shaext=0; ### set to zero if compiling for 1.0.1
$avx=1 if (!$shaext && $avx);
$shaext=1; ### set to zero if compiling for 1.0.1
nebeid marked this conversation as resolved.
Show resolved Hide resolved

open OUT,"| \"$^X\" \"$xlate\" $flavour \"$output\"";
*STDOUT=*OUT;
Expand Down Expand Up @@ -560,6 +556,7 @@ ()
.align 64
sha256_block_data_order_shaext:
_shaext_shortcut:
.cfi_startproc
___
$code.=<<___ if ($win64);
lea `-8-5*16`(%rsp),%rsp
Expand Down Expand Up @@ -703,6 +700,7 @@ ()
___
$code.=<<___;
ret
.cfi_endproc
.size sha256_block_data_order_shaext,.-sha256_block_data_order_shaext
___
}}}
Expand Down