Enable the SHA extension implementation of SHA-256/512 on x86 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables the implementation of SHA-256/512 with SHA extension instruction set on x86 platforms. Signed-off-by: Kostic <[email protected]>
dkostic
requested review from
andrewhop,
nebeid,
torben-hansen and
darylmartin100
|
If this change should not be merged before we have expanded our CI (which I agree with), can we park it in another branch? |
nebeid
reviewed
Dec 17, 2020
This commit adds a dispatch test for SHA extension instructions. Dispatch tests are meant to ensure that the expected assembly functions are triggered by high-level API calls.
andrewhop
reviewed
Dec 29, 2020
nebeid
previously approved these changes
Jan 5, 2021
andrew-kaufman
suggested changes
Jan 7, 2021
andrewhop
approved these changes
Jan 7, 2021
andrew-kaufman
approved these changes
Jan 8, 2021
aqjune
pushed a commit
to aqjune-aws/aws-lc-public
that referenced
this pull request
Sep 17, 2023
Add bignum_copy_row_from_table and its Neon-variants for AArch64 s2n-bignum original commit: awslabs/s2n-bignum@50aa85b
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Jul 22, 2024
Add bignum_copy_row_from_table and its Neon-variants for AArch64 s2n-bignum original commit: awslabs/s2n-bignum@50aa85b
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
Add bignum_copy_row_from_table and its Neon-variants for AArch64 s2n-bignum original commit: awslabs/s2n-bignum@50aa85b
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
Add bignum_copy_row_from_table and its Neon-variants for AArch64 s2n-bignum original commit: awslabs/s2n-bignum@50aa85b s2n-bignum original commit: awslabs/s2n-bignum@4b07e28
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 19, 2024
Add bignum_copy_row_from_table and its Neon-variants for AArch64 s2n-bignum original commit: awslabs/s2n-bignum@50aa85b
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Dec 5, 2024
Add bignum_copy_row_from_table and its Neon-variants for AArch64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the implementation of SHA-256/512 with
SHA extension instruction set on x86 platforms.
Signed-off-by: Kostic [email protected]
Issues:
Addresses CryptoAlg-599.
Description of changes:
This change enables the implementation of SHA-256/512 with
SHA extension instruction set on x86 platforms.
Call-outs:
The change should not be merged before it is ensured that the CI is running
code tests for all the possible CPU platforms. See CryptoAlg-622.
Testing:
See call-outs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.