-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keras notebook example #190
Conversation
mvsusp
commented
Feb 13, 2018
- Created a notebook example using Keras models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Just a couple of comments. Thanks!
"metadata": {}, | ||
"source": [ | ||
"### Download the CIFAR-10 dataset\n", | ||
"Downloading the test and training data will take around 5 minutes." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a link to the cifar datasets page as a reference?
"metadata": {}, | ||
"outputs": [], | ||
"source": [ | ||
"# Creating fake prediction data\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you're doing prediction on fake data? Why not use some records from the dataset itself? This might be a little bit easier for the user to follow.
Amazing! I am trying to do the same thing right now, but I gave up on the keras_model_fn due to errors I had no idea how to solve. I have an embedding model with users and items, but there seems to be some issues with the embedding sizes and lookups. Would love to get an example with embeddings. |
* Cherry picking change of refactor writers * set default step to 0 * remove histogram related stuff * rename IndexUtil * Fix imports * remove import of re * Fix step usage by event file writer * Fix import errors * Fix core test * undo utils change worker pid * fix import * fix import * do not flush index writer * review comments