Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bucket policy on DataplaneLogsBucket #739

Merged
merged 1 commit into from
Apr 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [5.1.1] - 2023-04-13

### Changed

* Updated the bucket policy on the DataplaneLogsBucket bucket(s) to grant access to the logging service principal (logging.s3.amazonaws.com) for access log delivery

## [5.1.0] - 2023-02-06

### Added
Expand Down
2 changes: 1 addition & 1 deletion deployment/lambda_layer_factory/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pymediainfo==4.2.1
jsonpickle==3.0.0
aws-xray-sdk==2.11.0
aws-xray-sdk==2.12.0
/packages/Media_Insights_Engine_Lambda_Helper-1.0.0-py3-none-any.whl
1 change: 1 addition & 0 deletions source/cdk/cdk.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"app": "npx ts-node bin/media-insights.ts",
"context": {
"@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy": true,
"solution_id": "SO0163",
"solution_name": "media-insights-on-aws",
"solution_version": "%%VERSION%%"
Expand Down
3 changes: 0 additions & 3 deletions source/cdk/lib/media-insights-stack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,6 @@ export class MediaInsightsStack extends Stack {
const dataplaneLogsBucket = new s3.Bucket(this, 'DataplaneLogsBucket', {
enforceSSL: true,
versioned: true,
accessControl: s3.BucketAccessControl.LOG_DELIVERY_WRITE,
encryption: s3.BucketEncryption.S3_MANAGED,
blockPublicAccess: s3.BlockPublicAccess.BLOCK_ALL,
});
Expand Down Expand Up @@ -390,8 +389,6 @@ export class MediaInsightsStack extends Stack {
],
});

dataplaneBucket.node.addDependency(dataplaneLogsBucket);


//
// Service - SNS
Expand Down
4 changes: 2 additions & 2 deletions source/cdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"@types/jest": "^27.0.0",
"@types/node": "^16.4.0",
"@types/sinon": "^10.0.2",
"aws-cdk": "^2.51.0",
"aws-cdk-lib": "^2.51.0",
"aws-cdk": "^2.73.0",
"aws-cdk-lib": "^2.73.0",
"constructs": "^10.0.9",
"jest": "^27.0.6",
"sinon": "^11.1.1",
Expand Down
4 changes: 2 additions & 2 deletions source/dataplanestream/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
simplejson==3.18.0
simplejson==3.19.1
jsonpickle==3.0.0
aws-xray-sdk==2.11.0
aws-xray-sdk==2.12.0
2 changes: 1 addition & 1 deletion source/workflowstream/requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
simplejson==3.18.0
simplejson==3.19.1
6 changes: 3 additions & 3 deletions test/unit/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ pytest==7.2.0
requests==2.28.1
urllib3==1.26.13
jsonschema==4.17.0
chalice==1.27.3
aws_xray_sdk==2.11.0
chalice==1.28.0
aws_xray_sdk==2.12.0
pytest-cov==4.0.0
simplejson==3.18.0
simplejson==3.19.1
pymediainfo==6.0.1
nltk==3.8.0
webvtt-py==0.4.6