Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bucket policy on DataplaneLogsBucket #739

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

dch90
Copy link
Contributor

@dch90 dch90 commented Apr 14, 2023

Background

An upcoming update on AWS S3 restricts that Bucket cannot have ACLs set with ObjectOwnership's BucketOwnerEnforced setting. To remediate this issue, the bucket policy is being updated to grant PutObject access to the logging service principal

Changes

  • Updated the bucket policy on the DataplaneLogsBucket bucket(s) to grant access to the logging service principal (logging.s3.amazonaws.com) for access log delivery
  • Updated outdated packages

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dch90 dch90 self-assigned this Apr 14, 2023
Copy link
Member

@eggoynes eggoynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Background
==========
An upcoming update on AWS S3 restricts that Bucket cannot have ACLs set with ObjectOwnership's BucketOwnerEnforced setting.
To remediate this issue, the bucket policy is being updated to grant PutObject access to the logging service principal

Changes
=======
* Updated the bucket policy on the DataplaneLogsBucket bucket(s) to grant access to the logging service principal (logging.s3.amazonaws.com) for access log delivery
* Updated outdated packages
@dch90 dch90 merged commit e73f621 into release/v5.1.1 Apr 17, 2023
@dch90 dch90 deleted the feature/v5.1.1 branch April 17, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants